Project

General

Profile

Cleanup #51379

mgr/volumes: add flake8 test

Added by Varsha Rao almost 3 years ago. Updated over 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

44%

Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
mgr/volumes
Labels (FS):
task(easy)
Pull request ID:

Subtasks

Cleanup #51380: mgr/volumes/module.py: fix various flake8 issuesResolved

Cleanup #51381: mgr/volumes/fs/async_job.py: fix various flake8 issuesResolved

Cleanup #51382: mgr/volumes/fs/async_cloner.py: fix various flake8 issuesFix Under Review

Cleanup #51383: mgr/volumes/fs/exception.py: fix various flake8 issuesFix Under ReviewManish Yathnalli

Cleanup #51384: mgr/volumes/fs/vol_spec.py: fix various flake8 issuesResolved

Cleanup #51385: mgr/volumes/fs/fs_util.py: add extra blank lineFix Under Review

Cleanup #51386: mgr/volumes/fs/volume.py: fix various flake8 issuesFix Under ReviewManish Yathnalli

Cleanup #51387: mgr/volumes/fs/purge_queue.py: add extra blank lineResolved

Cleanup #51388: mgr/volumes/fs/operations/index.py: add extra blank lineFix Under ReviewManish Yathnalli

Cleanup #51389: mgr/volumes/fs/operations/rankevicter.py: fix various flake8 issuesFix Under ReviewManish Yathnalli

Cleanup #51390: mgr/volumes/fs/operations/access.py: fix various flake8 issuesResolved

Cleanup #51391: mgr/volumes/fs/operations/resolver.py: add extra blank lineResolved

Cleanup #51392: mgr/volumes/fs/operations/snapshot_util.py: add extra blank lineResolved

Cleanup #51393: mgr/volumes/fs/operations/group.py: add extra blank lineResolved

Cleanup #51394: mgr/volumes/fs/operations/pin_util.py: fix various flake8 issuesFix Under ReviewManish Yathnalli

Cleanup #51395: mgr/volumes/fs/operations/lock.py: fix various flake8 issuesFix Under ReviewManish Yathnalli

Cleanup #51396: mgr/volumes/fs/operations/clone_index.py: fix various flake8 issuesResolved

Cleanup #51397: mgr/volumes/fs/operations/volume.py: fix various flake8 issuesFix Under ReviewManish Yathnalli

Cleanup #51398: mgr/volumes/fs/operations/subvolume.py: fix various flake8 issuesResolved

Cleanup #51399: mgr/volumes/fs/operations/template.py: fix various flake8 issuesFix Under ReviewManish Yathnalli

Cleanup #51400: mgr/volumes/fs/operations/trash.py: fix various flake8 issuesFix Under Review

Cleanup #51401: mgr/volumes/fs/operations/versions/metadata_manager.py: fix various flake8 issuesFix Under ReviewManish Yathnalli

Cleanup #51403: mgr/volumes/fs/operations/versions/auth_metadata.py: fix various flake8 issuesResolved

Cleanup #51404: mgr/volumes/fs/operations/versions/subvolume_v1.py: fix various flake8 issuesFix Under ReviewManish Yathnalli

Cleanup #51405: mgr/volumes/fs/operations/versions/subvolume_v2.py: fix various flake8 issuesFix Under ReviewManish Yathnalli

Cleanup #51406: mgr/volumes/fs/operations/versions/op_sm.py: fix various flake8 issuesFix Under Review

Cleanup #51407: mgr/volumes/fs/operations/versions/subvolume_attrs.py: fix various flake8 issuesResolved

History

#1 Updated by Varsha Rao almost 3 years ago

Before fixing these issues, make sure you have flake8 installed. You have read PEP 8 style guide1 and flake8 guide2.

Fix only the issues reported by
flake8 --ignore=E501,W503 src/pybind/mgr/volumes

Flake8 version used: 3.8.3 (mccabe: 0.6.1, pycodestyle: 2.6.0, pyflakes: 2.2.0) CPython 3.9.5 on Linux

If there any extra issues reported other than the ones mentioned in sub-tasks. Please add a comment about them and flake8 version used.

After fixing the issue, run flake8 again on the same file to ensure your patch does not introduce any new errors.

[1] https://www.python.org/dev/peps/pep-0008/
[2] https://flake8.pycqa.org/en/latest/user/index.html

#2 Updated by Patrick Donnelly over 1 year ago

  • Target version deleted (v17.0.0)

Also available in: Atom PDF