Project

General

Profile

Bug #51062

mds,client: suppport getvxattr RPC

Added by Jeff Layton about 2 years ago. Updated 11 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Milind Changire
Category:
Introspection/Control
Target version:
Ceph - v17.0.0
% Done:

100%

Source:
Development
Tags:
Backport:
quincy, pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client, MDS
Labels (FS):
task(medium)
Pull request ID:
42001
Crash signature (v1):
Crash signature (v2):

Description

Playing with ephemeral pinning today, and found that I can't query ceph.dir.pin.random:

[jlayton@client1 test]$ sudo setfattr -n ceph.dir.pin.random -v 0.5 ephemeral/
[jlayton@client1 test]$ sudo getfattr -n ceph.dir.pin.random  ephemeral/
ephemeral/: ceph.dir.pin.random: No such attribute

Most likely an oversight in the MDS xattr handling.

Related issues

Duplicated by CephFS - Bug #46438: mds: add vxattr for querying inherited layout Resolved
Copied to CephFS - Backport #54532: pacific: mds,client: suppport getvxattr RPC Resolved
Copied to CephFS - Backport #54533: quincy: mds,client: suppport getvxattr RPC Resolved

History

#1 Updated by Patrick Donnelly about 2 years ago

Jeff Layton wrote:

Playing with ephemeral pinning today, and found that I can't query ceph.dir.pin.random:

[...]

Most likely an oversight in the MDS xattr handling.

With libcephfs or kclient? We haven't wired these up yet.

#2 Updated by Jeff Layton about 2 years ago

kclient, but I don't think it matters. This is a server-side xattr, so it comes down to allowing it to be queried via handle_client_getxattr.

#3 Updated by Patrick Donnelly about 2 years ago

Jeff Layton wrote:

kclient, but I don't think it matters. This is a server-side xattr, so it comes down to allowing it to be queried via handle_client_getxattr.

The main challenge is that we either need to (a) pass these fields back to ht eclient in the inode data in the cap message or (b) develop a new getvxattr RPC just for learning some vxattrs. We keep needing to do (a) so I'm thinking it'd be a useful change to add a getvxattr RPC so only MDS-side changes are required in the future. In particular, this would be very helpful for getting the inherited layout on a directory (we have an open BZ for that somewhere).

#4 Updated by Milind Changire about 2 years ago

  • Status changed from New to Triaged
  • Assignee set to Milind Changire

#5 Updated by Milind Changire about 2 years ago

  • Status changed from Triaged to Fix Under Review
  • Pull request ID set to 42001

#6 Updated by Patrick Donnelly over 1 year ago

  • Tracker changed from Bug to Feature
  • Subject changed from ceph.dir.pin.random attribute can't be queried to mds,client: suppport getvxattr RPC
  • Category set to Introspection/Control
  • Target version set to v17.0.0
  • Source set to Development
  • Component(FS) Client, MDS added
  • Labels (FS) task(medium) added

#7 Updated by Venky Shankar over 1 year ago

  • Status changed from Fix Under Review to Resolved

#8 Updated by Venky Shankar over 1 year ago

  • Status changed from Resolved to Pending Backport
  • Backport set to quincy, pacific

#9 Updated by Backport Bot over 1 year ago

  • Copied to Backport #54532: pacific: mds,client: suppport getvxattr RPC added

#10 Updated by Backport Bot over 1 year ago

  • Copied to Backport #54533: quincy: mds,client: suppport getvxattr RPC added

#11 Updated by Patrick Donnelly about 1 year ago

  • Duplicated by Bug #46438: mds: add vxattr for querying inherited layout added

#12 Updated by Backport Bot about 1 year ago

  • Tags set to backport_processed

#13 Updated by Konstantin Shalygin 11 months ago

  • Tracker changed from Feature to Bug
  • Status changed from Pending Backport to Resolved
  • % Done changed from 0 to 100
  • Tags deleted (backport_processed)
  • Regression set to No
  • Severity set to 3 - minor

Also available in: Atom PDF