Project

General

Profile

Actions

Bug #5102

closed

mon: assert(is_active()) on propose_pending()

Added by Joao Eduardo Luis almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
High
Assignee:
Joao Eduardo Luis
Category:
Monitor
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

This bug popped up while Jim Schutt was trying to reproduce #4999

This was my reply to the assert:

The issue here is that at some point we back off a proposal on one of the PaxosServices and the proposal_timer is scheduled. However, it appears that something was updated leading to a 'Paxos::prepare_bootstrap()' [1], which by setting Paxos as 'going_to_bootstrap' makes 'PaxosService::is_active()' to return false and that assert to fail.

If this is indeed the cause, the easiest solution is fairly simple: just return on propose_pending() if we're going to bootstrap -- then again, this might make us lose the pending state; I guess this warrants another approach.

[1] - For clarity's sake, we use the prepare_bootstrap() approach so that we know that we must not schedule new proposals, but at the same time taking care of any currently queued proposals so that we don't end up losing them.

Jim's log file is attached.


Files

mon.cs28.log.bz2 (9.9 KB) mon.cs28.log.bz2 Joao Eduardo Luis, 05/17/2013 10:56 AM
Actions #1

Updated by Joao Eduardo Luis almost 11 years ago

  • Description updated (diff)
Actions #2

Updated by Joao Eduardo Luis almost 11 years ago

  • Status changed from In Progress to 4

wip-5102 has a proposed fix.

Actions #3

Updated by Joao Eduardo Luis almost 11 years ago

new fix on wip-5102, comprised of simply ripping out the prepare_bootstrap() stuff.

Actions #4

Updated by Sage Weil almost 11 years ago

  • Status changed from 4 to Fix Under Review
Actions #5

Updated by Sage Weil almost 11 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF