Project

General

Profile

Actions
Copy link

Bug #50931

closed

rbd-mirror: segfault on snapshot replayer on shutdown

Added by Arthur Outhenin-Chalandre almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Arthur Outhenin-Chalandre
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
octopus,pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
41480
Crash signature (v1):
Crash signature (v2):

Description

I had an issue in which the Snapshot Replayer (in `src/tools/rbd_mirror/image_replayer/snapshot/Replayer.cc`) init returned before the call on `register_local_update_watcher` with an error (this other issue will be followed up in another issue on the tracker). There are multiple error case in the init flow but if any error arise in it, the pointer `m_update_watch_ctx` will not be initialized.
At the shutdown phase, the `m_update_watch_ctx` will be freed and this makes the rbd-mirror daemon segfaults as it contains an uninitialized value.

Related issues 2 (0 open — 2 closed)

Copied to rbd - Backport #50941: octopus: rbd-mirror: segfault on snapshot replayer on shutdownResolvedIlya DryomovActions
Copied to rbd - Backport #50942: pacific: rbd-mirror: segfault on snapshot replayer on shutdownResolvedIlya DryomovActions
Actions
Copy link
 #1

Updated by Arthur Outhenin-Chalandre almost 3 years ago

Here is my PR fixing the issue: https://github.com/ceph/ceph/pull/41480.

Actions
Copy link
 #2

Updated by Ilya Dryomov almost 3 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Arthur Outhenin-Chalandre
  • Pull request ID set to 41480
Actions
Copy link
 #3

Updated by Ilya Dryomov almost 3 years ago

  • Project changed from Ceph to rbd
Actions
Copy link
 #4

Updated by Ilya Dryomov almost 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #5

Updated by Backport Bot almost 3 years ago

  • Copied to Backport #50941: octopus: rbd-mirror: segfault on snapshot replayer on shutdown added
Actions
Copy link
 #6

Updated by Backport Bot almost 3 years ago

  • Copied to Backport #50942: pacific: rbd-mirror: segfault on snapshot replayer on shutdown added
Actions
Copy link
 #7

Updated by Loïc Dachary almost 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF