Project

General

Profile

Cleanup #50827

pybind/mgr/CMakeLists.txt: exclude files not used at runtime

Added by Duncan Bellamy about 1 month ago. Updated about 1 month ago.

Status:
Fix Under Review
Priority:
Normal
Category:
-
Target version:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

pybind/mgr/CMakeLists.txt does not exclude node_modules

On alpine Linux ci some of the builders run out of disk space as it then appears in the source tree and the fake root install tree

Environment

  • ceph version string: all
  • Platform (OS/distro/release): Alpine Linux
  • Cluster details (nodes, monitors, OSDs): Alpine Linux ci builders
  • Browser used (e.g.: Version 86.0.4240.198 (Official Build) (64-bit)):

How reproducible

Use cmake to build and install Ceph

Actual results

node_modeules is in dest after make install

Expected results

node_modules is not in dest after make install as it is not used during runtime

Additional info

https://gitlab.alpinelinux.org/a16bitsysop/aports/-/jobs/392293/raw

History

#1 Updated by Duncan Bellamy about 1 month ago

With the patch it still fails:
https://gitlab.alpinelinux.org/a16bitsysop/aports/-/jobs/392681/raw

I am not sure what else in mgr/dashboard/frontend is not needed at runtime

#2 Updated by Duncan Bellamy about 1 month ago

It makes the build logs much smaller as well

#3 Updated by Alfonso Martínez about 1 month ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 41353

#4 Updated by Alfonso Martínez about 1 month ago

  • Assignee set to Duncan Bellamy

#5 Updated by Alfonso Martínez about 1 month ago

  • Subject changed from mgr/dashboard: short_description mgr/dashboard: short_description to pybind/mgr/CMakeLists.txt: exclude files not used at runtime

Also available in: Atom PDF