Actions
Cleanup #50827
closedpybind/mgr/CMakeLists.txt: exclude files not used at runtime
% Done:
0%
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:
Description
pybind/mgr/CMakeLists.txt does not exclude node_modules¶
On alpine Linux ci some of the builders run out of disk space as it then appears in the source tree and the fake root install tree
Environment¶
ceph versionstring: all- Platform (OS/distro/release): Alpine Linux
- Cluster details (nodes, monitors, OSDs): Alpine Linux ci builders
- Browser used (e.g.:
Version 86.0.4240.198 (Official Build) (64-bit)):
How reproducible¶
Use cmake to build and install Ceph
Actual results¶
node_modeules is in dest after make install
Expected results¶
node_modules is not in dest after make install as it is not used during runtime
Additional info¶
https://gitlab.alpinelinux.org/a16bitsysop/aports/-/jobs/392293/raw
Updated by Duncan Bellamy almost 3 years ago
With the patch it still fails:
https://gitlab.alpinelinux.org/a16bitsysop/aports/-/jobs/392681/raw
I am not sure what else in mgr/dashboard/frontend is not needed at runtime
Updated by Duncan Bellamy almost 3 years ago
It makes the build logs much smaller as well
Updated by Alfonso Martínez almost 3 years ago
- Status changed from New to Fix Under Review
- Pull request ID set to 41353
Updated by Alfonso Martínez almost 3 years ago
- Subject changed from mgr/dashboard: short_description mgr/dashboard: short_description to pybind/mgr/CMakeLists.txt: exclude files not used at runtime
Updated by Kefu Chai almost 3 years ago
- Status changed from Fix Under Review to Resolved
Updated by Ernesto Puerta almost 3 years ago
- Has duplicate Bug #43005: mgr/dashboard: RPM contains tests, front-end sources and non-releasable contents added
Updated by Yuri Weinstein over 2 years ago
Actions