Project

General

Profile

Bug #50442

cephfs-mirror: ignore snapshots on parent directories when synchronizing snapshots

Added by Venky Shankar 26 days ago. Updated 13 days ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Category:
Correctness/Safety
Target version:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Ignore syncing snapshots starting with an underscore since they are internally used by CephFS.


Related issues

Copied to CephFS - Backport #50629: pacific: cephfs-mirror: ignore snapshots on parent directories when synchronizing snapshots New

History

#1 Updated by Patrick Donnelly 26 days ago

Venky Shankar wrote:

Ignore syncing snapshots starting with an underscore since they are internally used by CephFS.

You mean snapshots on parent directories? Those are not "internal"?

#2 Updated by Venky Shankar 26 days ago

Patrick Donnelly wrote:

Venky Shankar wrote:

Ignore syncing snapshots starting with an underscore since they are internally used by CephFS.

You mean snapshots on parent directories? Those are not "internal"?

I meant internal representation such as::

# ls /mnt/syncvol1/volumes/_nogroup/subvol1/.snap
snap1

# ls /mnt/syncvol1/volumes/_nogroup/subvol1/c961c547-b954-4df5-a935-f8f07bb620eb/.snap
_snap1_1099511627779

... and /volumes/_nogroup/subvol1/c961c547-b954-4df5-a935-f8f07bb620eb is selected for snap mirroring.

#3 Updated by Patrick Donnelly 26 days ago

Venky Shankar wrote:

Patrick Donnelly wrote:

Venky Shankar wrote:

Ignore syncing snapshots starting with an underscore since they are internally used by CephFS.

You mean snapshots on parent directories? Those are not "internal"?

I meant internal representation such as::

[...]

... and /volumes/_nogroup/subvol1/c961c547-b954-4df5-a935-f8f07bb620eb is selected for snap mirroring.

Right but I'd rephrase the description: ignore snapshots on parent directories when considering snapshots to synchronize. Better or not?

#4 Updated by Venky Shankar 26 days ago

  • Subject changed from cephfs-mirror: ignore internal snapshots during synchronization to cephfs-mirror: ignore snapshots on parent directories when synchronizing snapshots

Patrick Donnelly wrote:

Venky Shankar wrote:

Patrick Donnelly wrote:

Venky Shankar wrote:

Ignore syncing snapshots starting with an underscore since they are internally used by CephFS.

You mean snapshots on parent directories? Those are not "internal"?

I meant internal representation such as::

[...]

... and /volumes/_nogroup/subvol1/c961c547-b954-4df5-a935-f8f07bb620eb is selected for snap mirroring.

Right but I'd rephrase the description: ignore snapshots on parent directories when considering snapshots to synchronize. Better or not?

spot on.

#5 Updated by Venky Shankar 26 days ago

  • Status changed from New to In Progress

#6 Updated by Venky Shankar 26 days ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 40962

#7 Updated by Patrick Donnelly 13 days ago

  • Status changed from Fix Under Review to Pending Backport

#8 Updated by Backport Bot 13 days ago

  • Copied to Backport #50629: pacific: cephfs-mirror: ignore snapshots on parent directories when synchronizing snapshots added

Also available in: Atom PDF