Project

General

Profile

Bug #49891

octopus: _osd_in_out_completed_events_count() was used without declaration

Added by Kamoltat (Junior) Sirivadhna about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
progress module
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

https://github.com/ceph/ceph/pull/39289 was an incomplete backport where the function _osd_in_out_completed_events_count() was used without declaration as
a result:

2021-03-12T01:41:14.893 INFO:tasks.cephfs_test_runner:======================================================================
2021-03-12T01:41:14.893 INFO:tasks.cephfs_test_runner:ERROR: test_osd_cannot_recover (tasks.mgr.test_progress.TestProgress)
2021-03-12T01:41:14.893 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2021-03-12T01:41:14.894 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2021-03-12T01:41:14.894 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/github.com_ceph_ceph-c_dbb79e0547db3abf076b9bc9b6ad97ede0519a0e/qa/tasks/mgr/test_progress.py", line 352, in test_osd_cannot_recover
2021-03-12T01:41:14.895 INFO:tasks.cephfs_test_runner: self._osd_in_out_completed_events_count('out'),
2021-03-12T01:41:14.895 INFO:tasks.cephfs_test_runner:AttributeError: 'TestProgress' object has no attribute '_osd_in_out_completed_events_count'
2021-03-12T01:41:14.896 INFO:tasks.cephfs_test_runner:
2021-03-12T01:41:14.896 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2021-03-12T01:41:14.896 INFO:tasks.cephfs_test_runner:Ran 2 tests in 157.386s
2021-03-12T01:41:14.897 INFO:tasks.cephfs_test_runner:
2021-03-12T01:41:14.897 INFO:tasks.cephfs_test_runner:FAILED (errors=1)
2021-03-12T01:41:14.897 INFO:tasks.cephfs_test_runner:
2021-03-12T01:41:14.897 INFO:tasks.cephfs_test_runner:======================================================================
2021-03-12T01:41:14.898 INFO:tasks.cephfs_test_runner:ERROR: test_osd_cannot_recover (tasks.mgr.test_progress.TestProgress)
2021-03-12T01:41:14.898 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2021-03-12T01:41:14.899 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2021-03-12T01:41:14.899 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/github.com_ceph_ceph-c_dbb79e0547db3abf076b9bc9b6ad97ede0519a0e/qa/tasks/mgr/test_progress.py", line 352, in test_osd_cannot_recover
2021-03-12T01:41:14.899 INFO:tasks.cephfs_test_runner: self._osd_in_out_completed_events_count('out'),
2021-03-12T01:41:14.899 INFO:tasks.cephfs_test_runner:AttributeError: 'TestProgress' object has no attribute '_osd_in_out_completed_events_count'

/ceph/teuthology-archive/yuriw-2021-03-09_20:27:38-rados-wip-yuri2-testing-2021-03-09-1006-octopus-distro-basic-smithi/5950994/teuthology.log

Fix Under Review with PR: https://github.com/ceph/ceph/pull/40225

History

#1 Updated by Kamoltat (Junior) Sirivadhna about 3 years ago

  • Description updated (diff)
  • Status changed from New to Fix Under Review

#2 Updated by Kamoltat (Junior) Sirivadhna about 3 years ago

  • Status changed from Fix Under Review to Resolved

#3 Updated by Loïc Dachary about 3 years ago

  • Pull request ID set to 40225

Also available in: Atom PDF