Project

General

Profile

Actions
Copy link

Bug #49872

closed

cephadm: Don't remove the daemon keyring, if redeploy failes

Added by Sebastian Wagner about 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
Melissa Li
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
low-hanging-fruit
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
40459
Crash signature (v1):
Crash signature (v2):

Description

This code block is also executed when redeploying a daemon:

https://github.com/ceph/ceph/blob/28b5137da73c3fa74e1dca51df3390f465a21d33/src/pybind/mgr/cephadm/serve.py#L899-L903

Instead, we should only remove the keyring, if the daemon was not previously deployed.

Related issues 1 (0 open — 1 closed)

Related to Orchestrator - Bug #48164: Orchestrator: failed deployments leave orphaned auth entriesResolved

Actions
Actions
Copy link
 #1

Updated by Sebastian Wagner about 3 years ago

  • Related to Bug #48164: Orchestrator: failed deployments leave orphaned auth entries added
Actions
Copy link
 #2

Updated by Melissa Li about 3 years ago

  • Assignee set to Melissa Li
Actions
Copy link
 #3

Updated by Kefu Chai about 3 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 40459
Actions
Copy link
 #4

Updated by Sage Weil about 3 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport set to pacific
Actions
Copy link
 #5

Updated by Sebastian Wagner almost 3 years ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link

Also available in: Atom PDF