Actions
Bug #49626
closedcephadm: remove duplicate labels when adding a host
% Done:
0%
Source:
Tags:
Backport:
pacific,octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Description
right now, the "ceph orch host label add" command with cephadm will only add a label if it is not already attached to the host. However, when including labels using the "ceph orch host add" command with cephadm it's possible to create a host with duplicate labels which have to be removed one at a time to get rid of them. Adding a host should be consistent with adding a label and not add duplicates.
[ceph: root@vm-00 /]# ceph orch host ls HOST ADDR LABELS STATUS vm-00 vm-00 vm-01 vm-01 [ceph: root@vm-00 /]# ceph orch host add vm-02 192.168.122.48 osd osd osd Added host 'vm-02' [ceph: root@vm-00 /]# ceph orch host ls HOST ADDR LABELS STATUS vm-00 vm-00 vm-01 vm-01 vm-02 192.168.122.48 osd osd osd [ceph: root@vm-00 /]# ceph orch host label rm vm-02 osd Removed label osd from host vm-02 [ceph: root@vm-00 /]# ceph orch host ls HOST ADDR LABELS STATUS vm-00 vm-00 vm-01 vm-01 vm-02 192.168.122.48 osd osd [ceph: root@vm-00 /]# ceph orch host label rm vm-02 osd Removed label osd from host vm-02 [ceph: root@vm-00 /]# ceph orch host ls HOST ADDR LABELS STATUS vm-00 vm-00 vm-01 vm-01 vm-02 192.168.122.48 osd
Updated by Adam King about 3 years ago
- Status changed from New to Fix Under Review
- Pull request ID set to 39857
Updated by Adam King about 3 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Sage Weil about 3 years ago
- Backport set to pacific,octopus
pacific backport merged in https://github.com/ceph/ceph/pull/40135
Updated by Sebastian Wagner almost 3 years ago
- Status changed from Pending Backport to Resolved
Actions