Project

General

Profile

Actions
Copy link

Bug #4941

closed

rbd: only set up watch for mapped images

Added by Alex Elder almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Alex Elder
Category:
-
Target version:
v0.62b
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Any changes to parent images are immaterial to any mapped clone.
So there is no need to have a watch event registered on header
objects except for the header object of an image that is mapped.

We can't set up the watch request until we know the name of the
header object though. So pass a flag to rbd_dev_image_probe() to
indicate whether this probe is for a mapping or for a parent image.

Change the second parameter to rbd_dev_header_watch_sync() be
Boolean while we're at it.

Signed-off-by: Alex Elder <>

Actions
Copy link
 #1

Updated by Alex Elder almost 11 years ago

I added this to the patch description:

In fact, a watch request is a write operation, and we may only
have read access to a parent image.

Actions
Copy link
 #2

Updated by Alex Elder almost 11 years ago

  • Status changed from In Progress to Fix Under Review

The following has been posted for review. It is one of
the patches available in the "review/wip-rbd-cleanup-2"
branch of the ceph-client git repository.

[PATCH 4/5] rbd: only set up watch for mapped images

Actions
Copy link
 #3

Updated by Alex Elder almost 11 years ago

  • Status changed from Fix Under Review to Resolved

The following has been committed to the ceph-client
"testing-next" branch.

1f3ef78 rbd: only set up watch for mapped images

Actions
Copy link

Also available in: Atom PDF