Project

General

Profile

Bug #48866

The interface code about group list is redundant

Added by David Lee about 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

At librbd::api::group::list,the code is redundant,like:
if (r == -ENOENT) {
return 0; // Ignore missing rbd group directory. It means we don't have any groups yet.
}
if (r < 0) {
if (r != -ENOENT) {
lderr(cct) << "error listing group in directory: "
<< cpp_strerror(r) << dendl;
} else {
r = 0;
}
return r;
}
I think the first if judgment can be removed.

History

#1 Updated by Jason Dillaman about 2 years ago

  • Status changed from New to Resolved

#2 Updated by Jason Dillaman about 2 years ago

  • Pull request ID set to 38898

Also available in: Atom PDF