Project

General

Profile

Actions
Copy link

Bug #48863

closed

cephfs-shell should allow changing all mode bits

Added by Jeff Layton over 3 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Neeraj Pratap Singh
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
cephfs-shell
Labels (FS):
Pull request ID:
45776
Crash signature (v1):
Crash signature (v2):

Description

Currently, cephfs-shell says:

CephFS:~/>>> chmod 01777 scratch
usage: chmod [-h] mode paths [paths ...]
chmod: error: invalid mode: 01777
mode cannot be greater than octal 0777

What that should probably do is just not allow you to change anything that's in the S_IFMT mask (see /usr/include/linux/stat.h).

Actions
Copy link
 #1

Updated by Jeff Layton over 3 years ago

The issue is that you can't currently set S_ISUID, S_ISGID or S_ISVTX. We should allow that within cephfs-shell.

IOW, the allowable mask should be 07777.

Actions
Copy link
 #2

Updated by Neeraj Pratap Singh about 2 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Neeraj Pratap Singh
  • Pull request ID set to 45776
Actions
Copy link
 #3

Updated by Venky Shankar almost 2 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link

Also available in: Atom PDF