Project

General

Profile

Bug #4880

Bug #4868: rbd: kill off the snapshot list

krbd: clear EXISTS flag if mapped snapshot disappears

Added by Alex Elder almost 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

This commit removed the rbd device snapshot list:
17e4749 rbd: kill off the snapshot list

It inadvertently removed the code that cleared
the EXISTS flag from removed snapshots (something
noted by ace reviewer Josh Durgin.

That needs to go back. Just scan the snapshot
context to see if it is found in the array, and
if not, clear the flag.

History

#1 Updated by Alex Elder almost 7 years ago

  • Status changed from In Progress to Fix Under Review

The following patches have been posted for review.
They are available in the "review/wip-slabs" branch
of the ceph-client git repository.

The first patch in this series puts back some functionality
that was deleted inadvertently by the previous commit. Josh
pointed out it had disappeared. The second one replaces a
linear search of snapshot ids with a binary search for
efficiency.

-Alex

[PATCH 1/2] rbd: clear EXISTS flag if mapped snapshot disappears
[PATCH 2/2] rbd: use binary search for snapshot lookup

#2 Updated by Alex Elder almost 7 years ago

  • Status changed from Fix Under Review to Resolved

The following have been committed to the "testing" branch
of the ceph-client git repository:

15228ed rbd: clear EXISTS flag if mapped snapshot disappears
30d1cff rbd: use binary search for snapshot lookup

Also available in: Atom PDF