Ceph » rgw

The full warning:

[3/10] Building CXX object src/rgw/CMakeFiles/radosgw.dir/rgw_rest_metadata.cc.o
../src/rgw/rgw_rest_metadata.cc:267:13: warning: address of 'this->ondisk_version' will always evaluate to 'true' [-Wpointer-bool-conversion]
                                       &ondisk_version);
                                        ^~~~~~~~~~~~~~

op_ret = store->ctl()->meta.mgr->put(metadata_key, bl, s->yield, sync_type,
      &ondisk_version);
       ^^^^^^^^^^^^^^
--> 
int RGWMetadataManager::put(string& metadata_key, bufferlist& bl,
                optional_yield y,
                            RGWMDLogSyncType sync_type,
                            bool from_remote_zone,
                            ^^^vvv
                            obj_version *existing_version)

Quote:
- - - - - 8< - - - - -
Ronen Friedman
Dec 14, 2020, 1:35 PM (7 days ago)
to me, Casey

Hi,

Seems there's a missing argument in the call to 'put()' in line 266
of this file:

op_ret = store->ctl()->meta.mgr->put(metadata_key, bl, s->yield, sync_type,
      &ondisk_version);

The last parameter is taken to be a bool. If this is what it was meant to be, well, the
compiler doesn't like the fact that bool is always true. I assume that the problem is that
the wrong 'put' is selected?

Thanks
Ronen
- - - - - 8< - - - - -