Project

General

Profile

Actions

Bug #48609

closed

Bug #48417: unfound EC objects in sepia's LRC after upgrade

osd/PGLog: don’t fast-forward can_rollback_to during merge_log if the log isn’t extended

Added by Neha Ojha over 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Urgent
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
pacific, octopus, nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

(a) Doing so is wrong specifically for intervals where we go peered but not active.
See PGLog.cc:456, we unconditionally rollforward to log.head but only actually should if append_log_entries_update_missing actually extends the log. https://tracker.ceph.com/issues/48417#note-12

(b) pg log unit tests to ensure that crt doesn’t get fast forwarded during merge_log unless the auth log is longer(has new items)

Actions #1

Updated by Deepika Upadhyay over 3 years ago

  • Assignee set to Deepika Upadhyay
Actions #2

Updated by Neha Ojha over 3 years ago

  • Status changed from New to In Progress
  • Pull request ID set to 38906
Actions #3

Updated by Neha Ojha about 3 years ago

  • Status changed from In Progress to Fix Under Review
  • Backport set to pacific, octopus, nautilus
Actions #4

Updated by Deepika Upadhyay almost 3 years ago

  • Status changed from Fix Under Review to Closed

Root cause resolved

Actions

Also available in: Atom PDF