Project

General

Profile

Actions
Copy link

Bug #48553

closed

[rbd-mirror] create primary snapshot state machine is deleting incorrect snapshot

Added by Jason Dillaman over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
Jason Dillaman
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
38536
Crash signature (v1):
Crash signature (v2):

Description

When you have a maximum of >=3 snapshots, we should always keep the old 2 snapshots since those are the two snapshots that "rbd-mirror" will be using for sync. If "rbd-mirror" falls behind and reaches the snapshot limit (>=3), deletion of the third snapshot should occur. Currently, an in-progress snapshot sync could have its snapshot deleted out from underneath it.

Related issues 1 (0 open — 1 closed)

Copied to rbd - Backport #48627: octopus: [rbd-mirror] create primary snapshot state machine is deleting incorrect snapshotResolvedJason DillamanActions
Actions
Copy link
 #1

Updated by Jason Dillaman over 3 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 38536
Actions
Copy link
 #2

Updated by Mykola Golub over 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #3

Updated by Backport Bot over 3 years ago

  • Copied to Backport #48627: octopus: [rbd-mirror] create primary snapshot state machine is deleting incorrect snapshot added
Actions
Copy link
 #4

Updated by Loïc Dachary about 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF