Actions
Bug #4829
closedclient: handling part of MClientForward incorrectly?
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client
Labels (FS):
multimds
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
(In reference to a backwards check for is_replay when doing encode_cap_releases())
Greg isn't that backwards? only encoding the releases if we got an unsafe reply? Sage Weil argh btw i suspect this is also wrong wrt forwards Greg backwards logic? I haven't seen your patches for it yet Sage Weil fixed that i mean, i think we only want to do this the first attempt for the request, not each time we forward. but that needs a careful look at handling for the MClientForward stuff like, that swap() obviously will only work the first time around.. but the other encode_cap_releases() will do it each tie time so at the very least its slightly wrong
Updated by Greg Farnum about 10 years ago
- Priority changed from High to Low
Demoting due to uclient and multi-mds.
Updated by Greg Farnum almost 8 years ago
- Category changed from 46 to 90
- Component(FS) Client added
Updated by John Spray over 7 years ago
- Priority changed from Low to High
- Target version set to v12.0.0
Targeting for Luminous to investigate and either fix or close this.
Updated by Zheng Yan over 7 years ago
I can't see why we shouldn't encode cap releases after receiving MClientForward. The old releases is for the old MDS, the new releases is for the new target mds
Updated by Patrick Donnelly about 5 years ago
- Category deleted (
90) - Labels (FS) multimds added
Actions