Bug #48258: mgr/dashboard: Switch from tslint to eslint - Dashboard - Ceph

Bug #48258

mgr/dashboard: Switch from tslint to eslint

Added by Volker Theile almost 3 years ago. Updated 7 months ago.

Status:

Resolved

Priority:

Low

Assignee:

Category:

UI

Target version:

% Done:

0%

Source:

Development

Tags:

backport_processed

Backport:

quincy

Regression:

No

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Tags:

dashboard_sprint_23

Description

tslint is deprecated, so the Dashboard should switch to eslint.

See https://tracker.ceph.com/issues/48258#note-4

Adi went deeper into this: https://docs.google.com/document/d/1gs5lUkIyT5dGoVW1nGloZRFzEEl57D3p6DGBLX7zY1Y/edit

Related issues

History

#1 Updated by Ernesto Puerta almost 3 years ago

Good finding, thanks Volker! Any clue on how easy/hard would this be to do?

#2 Updated by Ernesto Puerta almost 3 years ago

Status changed from New to Triaged
Priority changed from Normal to Low

#3 Updated by Ernesto Puerta over 2 years ago

Project changed from mgr to Dashboard
Category changed from 165 to UI

#4 Updated by Alfonso Martínez over 2 years ago

Assignee changed from Volker Theile to Alfonso Martínez

We should follow this guide:
https://github.com/angular-eslint/angular-eslint#migrating-an-angular-cli-project-from-codelyzer-and-tslint

#5 Updated by Alfonso Martínez over 2 years ago

Description updated (diff)

#6 Updated by Ernesto Puerta about 2 years ago

Tags set to dashboard_sprint_23

#7 Updated by Kefu Chai almost 2 years ago

Status changed from Triaged to Fix Under Review
Pull request ID set to 43480

#8 Updated by Ernesto Puerta over 1 year ago

Description updated (diff)

#9 Updated by Ernesto Puerta over 1 year ago

Alfonso Martínez wrote:

We should follow this guide:
https://github.com/angular-eslint/angular-eslint#migrating-an-angular-cli-project-from-codelyzer-and-tslint

A tool for automating that:
https://github.com/typescript-eslint/tslint-to-eslint-config

There's another PR trying this: https://github.com/ceph/ceph/pull/45767

#10 Updated by Ngwa Sedrick Meh 11 months ago

Hi, will like to work on this one

#11 Updated by Nizamudeen A 11 months ago

great, thanks Sedrick. you can assign it to you. There are two PRs opened currently. You can go over the discussions inside them and continue with it https://github.com/ceph/ceph/pull/43480, https://github.com/ceph/ceph/pull/45767. It'll give you some ideas.

#12 Updated by Ngwa Sedrick Meh 11 months ago

Thanks Nizam, will get working

#13 Updated by Ngwa Sedrick Meh 11 months ago

Assignee changed from Alfonso Martínez to Ngwa Sedrick Meh

#14 Updated by Nizamudeen A 10 months ago

Status changed from Fix Under Review to Pending Backport
Assignee changed from Ngwa Sedrick Meh to Nizamudeen A
Pull request ID changed from 43480 to 48569

#15 Updated by Backport Bot 10 months ago

Tags set to backport_processed

#16 Updated by Nizamudeen A 7 months ago

Backport set to quincy

#17 Updated by Nizamudeen A 7 months ago

Status changed from Pending Backport to Fix Under Review

#18 Updated by Nizamudeen A 7 months ago

Status changed from Fix Under Review to Pending Backport
Tags deleted (~~backport_processed~~)

#19 Updated by Backport Bot 7 months ago

Copied to Backport #58730: quincy: mgr/dashboard: Switch from tslint to eslint added

#20 Updated by Backport Bot 7 months ago

Tags set to backport_processed

#21 Updated by Nizamudeen A 7 months ago

Status changed from Pending Backport to Resolved

Also available in: Atom PDF