Bug #48205: cephadm: last local ceph image tag can be null - Orchestrator - Ceph

Actions

Copy link

Bug #48205

closed

cephadm: last local ceph image tag can be null

Added by Michael Fritch over 3 years ago. Updated over 3 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Michael Fritch

Category:

cephadm (binary)

Target version:

% Done:

Source:

Development

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

38032

Crash signature (v1):

Crash signature (v2):

Description

$ cephadm shell
Inferring fsid 0d848f8c-23ce-11eb-8fe2-3ab7774c4e84
Inferring config /var/lib/ceph/0d848f8c-23ce-11eb-8fe2-3ab7774c4e84/mon.host3/config
Using recent ceph image docker.io/ceph/daemon-base:<none>
Non-zero exit code 125 from /usr/bin/podman run --rm --ipc=host --net=host --entrypoint stat --init -e CONTAINER_IMAGE=docker.io/ceph/daemon-base:<none> -e NODE_NAME=host3 docker.io/ceph/daemon-base:<none> -c %u %g /var/lib/ceph
stat:stderr Error: invalid reference format
Traceback (most recent call last):
  File "../src/cephadm/cephadm", line 6067, in <module>
    r = args.func()
  File "../src/cephadm/cephadm", line 1300, in _infer_fsid
    return func()
  File "../src/cephadm/cephadm", line 1331, in _infer_config
    return func()
  File "../src/cephadm/cephadm", line 1359, in _infer_image
    return func()
  File "../src/cephadm/cephadm", line 3449, in command_shell
    make_log_dir(args.fsid)
  File "../src/cephadm/cephadm", line 1454, in make_log_dir
    uid, gid = extract_uid_gid()
  File "../src/cephadm/cephadm", line 2059, in extract_uid_gid
    raise RuntimeError('uid/gid not found')
RuntimeError: uid/gid not found

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Michael Fritch over 3 years ago

Description updated (diff)

Actions

Copy link

Updated by Michael Fritch over 3 years ago

`--filter dangling=false` does not appear to trim the list when the image tag is null

podman images --filter label=ceph=True --filter dangling=false --format '{{.Repository}} {{.Tag}}'
docker.io/ceph/daemon-base <none>
docker.io/ceph/daemon-base latest-master-devel
docker.io/ceph/daemon-base latest-nautilus
docker.io/ceph/daemon-base latest-octopus
quay.ceph.io/ceph-ci/ceph fd17cab9b9ee79193a2ef14ad4bd2aed6a66c564
docker.io/ceph/daemon-base <none>
docker.io/ceph/daemon-base <none>
docker.io/ceph/daemon-base <none>
docker.io/ceph/daemon-base <none>
docker.io/ceph/daemon-base <none>
docker.io/ceph/daemon-base <none>
docker.io/ceph/ceph v15
docker.io/ceph/daemon-base <none>

Actions

Copy link

Updated by Michael Fritch over 3 years ago

Filtering this out to the list of image names seems more reasonable:

podman images --filter label=ceph=True --filter dangling=false --format '{{.Names}}'
[docker.io/ceph/daemon-base@sha256:efd5679bb9d4ba3435e6a6713d96b4abd70a37fda790e99c20a5fc02d1b7b257]
[docker.io/ceph/daemon-base:latest-master-devel docker.io/ceph/daemon-base@sha256:94763cc73ed6428edc7441c4d7ab309cf183efd6b6d6913bda8255365923f78e]
[docker.io/ceph/daemon-base:latest-nautilus]
[docker.io/ceph/daemon-base:latest-octopus]
[quay.ceph.io/ceph-ci/ceph:fd17cab9b9ee79193a2ef14ad4bd2aed6a66c564]

Actions

Copy link

Updated by Michael Fritch over 3 years ago

Pull request ID set to 38032

Actions

Copy link

Updated by Michael Fritch over 3 years ago

Status changed from New to Fix Under Review

Actions

Copy link

Updated by Sebastian Wagner over 3 years ago

Has duplicate Bug #48277: cephadm infer image: <none>:<none>, despite --filter dangling=false added

Actions

Copy link

Updated by Michael Fritch over 3 years ago

PR has been updated to use a repository digest, because the image names are not available when using docker.

digest works for both podman/docker and is likely more reliable than the repo/tag anyway:

podman images --filter label=ceph=True --filter dangling=false --format '{{.Repository}}@{{.Digest}}'
docker.io/ceph/daemon-base@sha256:efd5679bb9d4ba3435e6a6713d96b4abd70a37fda790e99c20a5fc02d1b7b257
docker.io/ceph/daemon-base@sha256:94763cc73ed6428edc7441c4d7ab309cf183efd6b6d6913bda8255365923f78e
docker.io/ceph/daemon-base@sha256:5ad7df0fd49d559dfc57123e3d6088cfe8e9e95435e6e063262109d1fc5493f1
docker.io/ceph/daemon-base@sha256:dc86e624ba095d1e5fb8e2eb8b0cac7eab93335aa35e2248be583d8832b429f8

Actions

Copy link