Project

General

Profile

Actions

Bug #4810

closed

mon: forwarded messages have weird priorities

Added by Sage Weil almost 11 years ago. Updated almost 11 years ago.

Status:
Won't Fix
Priority:
High
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

While testing #4748, i'm seeing MForward messages between monitors getting lost. they are enqueued by read_message, but the dispatch thread skips them and delivers a later seq #. this stalls commands like 'ceph osd in 1' and makes the job hang. see teuthology:/a/sage-e3/388 for a sample

Actions #1

Updated by Ian Colle almost 11 years ago

  • Assignee set to Sage Weil
Actions #2

Updated by Sage Weil almost 11 years ago

  • Subject changed from msgr: losing messages in DispatchQueue to mon: forwarded messages have weird priorities
  • Status changed from New to In Progress

actually this was the forwards taking the priority from the client msg. fixed that in wip-4748-b and running tests in sage-e5

Actions #3

Updated by Sage Weil almost 11 years ago

which was problematic because of

ceph_mon.cc:  messenger->set_default_send_priority(CEPH_MSG_PRIO_HIGH);

but that is probably not worth changing now. nothing in mon/* sets a prio, so everything sent by the mon will be high.

Actions #4

Updated by Sage Weil almost 11 years ago

  • Priority changed from Urgent to High

wip-mon-fwd

Actions #5

Updated by Greg Farnum almost 11 years ago

We've discussed this and are not sure if we want to change the way prioritization works or not. The observable symptom has been dealt with by the osd epoch caching that we put into next.

Actions #6

Updated by Sage Weil almost 11 years ago

  • Status changed from In Progress to Won't Fix

current behavior is ok. for now clients can get equal priority if they want it by setting to HIGH; currently all are NORMAL. we may want to change that later.

Actions

Also available in: Atom PDF