Project

General

Profile

Actions

Bug #48077

closed

Allowing scrub configs begin_day/end_day to include 7 and begin_hour/end_hour to include 24 is confusing

Added by David Zafman over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
David Zafman
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

- Make the range of "osd scrub begin/end week day" 0-6 in options.cc
- Handle code in [1] to deal with this and test with existing value of 7
- Update docs in [2] and make a note about 0/0 to be values needed to
allow scrubbing the entire week

[1] Code: https://github.com/ceph/ceph/blob/nautilus/src/osd/OSD.cc#L7865
[2] Docs: https://docs.ceph.com/en/latest/rados/configuration/osd-config-ref/#scrubbing


Related issues 1 (1 open0 closed)

Related to mgr - Bug #49086: balancer: make {begin,end}_weekday selection compatible with osd_scrub_{begin,end}_week_dayFix Under Review

Actions
Actions #1

Updated by David Zafman over 3 years ago

  • Pull request ID set to 37941
Actions #2

Updated by David Zafman over 3 years ago

  • Status changed from New to Fix Under Review
Actions #3

Updated by David Zafman over 3 years ago

  • Status changed from Fix Under Review to Resolved
Actions #4

Updated by David Zafman about 3 years ago

  • Related to Bug #49086: balancer: make {begin,end}_weekday selection compatible with osd_scrub_{begin,end}_week_day added
Actions

Also available in: Atom PDF