Project

General

Profile

Cleanup #48051

mgr/dashboard: Use pipe instead of calling function within template

Added by Volker Theile 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Volker Theile
Category:
dashboard/UI
Target version:
Ceph - v16.0.0
% Done:

0%

Tags:
Backport:
octopus
Reviewed:
Affected Versions:
Ceph - v16.0.0
Pull request ID:
37993

Description

Use pipes instead of calling functins from within templates to reduce the number of calls during Angular change detection.

See https://blog.appverse.io/why-it-is-a-bad-idea-to-use-methods-in-the-html-templates-with-angular-2-30d49f0d3b16

Related issues

Related to mgr - Bug #47494: mgr/dashboard: Dashboard becomes unresponsive when SMART data not available Resolved
Related to mgr - Cleanup #48181: mgr/dashboard: Use pipe instead of calling function within template wherever possible Pending Backport
Duplicates mgr - Bug #42908: mgr/dashboard: some components call repeatedly the same method (up to 12 times/second) In Progress
Copied to mgr - Backport #48226: octopus: mgr/dashboard: Use pipe instead of calling function within template Resolved

History

#1 Updated by Volker Theile 3 months ago

  • Related to Bug #47494: mgr/dashboard: Dashboard becomes unresponsive when SMART data not available added

#2 Updated by Volker Theile 3 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 37905

#3 Updated by Ernesto Puerta 3 months ago

  • Duplicates Bug #42908: mgr/dashboard: some components call repeatedly the same method (up to 12 times/second) added

#4 Updated by Volker Theile 3 months ago

  • Pull request ID changed from 37905 to 37993

#5 Updated by Volker Theile 3 months ago

  • Related to Cleanup #48181: mgr/dashboard: Use pipe instead of calling function within template wherever possible added

#6 Updated by Ernesto Puerta 3 months ago

  • Status changed from Fix Under Review to Pending Backport

#7 Updated by Nathan Cutler 3 months ago

  • Copied to Backport #48226: octopus: mgr/dashboard: Use pipe instead of calling function within template added

#8 Updated by Nathan Cutler about 1 month ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Also available in: Atom PDF