Project

General

Profile

Actions
Copy link

Bug #48047

closed

osd: fix bluestore stupid allocator

Added by yantao xue over 3 years ago. Updated almost 3 years ago.

Status:
Rejected
Priority:
Low
Assignee:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
Ceph - v16.0.0
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

In StupidAllocator::_choose_bin, it uses cct->_conf->bdev_block_size that can be changed in the allocator running,but we had free space enxtens in 10 free trees with the old bdev_block_size, so the _choose_bin will give a wrong bin that is as the index of 10 free trees for the user has changed the bdev_block_size through osd asok config set command.

Actions
Copy link
 #1

Updated by Igor Fedotov over 3 years ago

  • Project changed from CephFS to bluestore
Actions
Copy link
 #2

Updated by Igor Fedotov over 3 years ago

  • Priority changed from Normal to Low

IMO bdev_block_size should be marked with FLAG_STARTUP (or even FLAG_CREATE) and hence protected from the modification. I don't see much rationale in changing it on the fly...

Actions
Copy link
 #3

Updated by Igor Fedotov almost 3 years ago

  • Status changed from New to Rejected
Actions
Copy link

Also available in: Atom PDF