Project

General

Profile

Bug #48047

osd: fix bluestore stupid allocator

Added by yantao xue 9 months ago. Updated about 2 months ago.

Status:
Rejected
Priority:
Low
Assignee:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

In StupidAllocator::_choose_bin, it uses cct->_conf->bdev_block_size that can be changed in the allocator running,but we had free space enxtens in 10 free trees with the old bdev_block_size, so the _choose_bin will give a wrong bin that is as the index of 10 free trees for the user has changed the bdev_block_size through osd asok config set command.

History

#1 Updated by Igor Fedotov 9 months ago

  • Project changed from CephFS to bluestore

#2 Updated by Igor Fedotov 9 months ago

  • Priority changed from Normal to Low

IMO bdev_block_size should be marked with FLAG_STARTUP (or even FLAG_CREATE) and hence protected from the modification. I don't see much rationale in changing it on the fly...

#3 Updated by Igor Fedotov about 2 months ago

  • Status changed from New to Rejected

Also available in: Atom PDF