Project

General

Profile

Actions

Feature #47827

closed

scale up rbd mirror snapshot scheduler

Added by Mykola Golub over 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
octopus
Reviewed:
Affected Versions:
Pull request ID:

Description

Right now the rbd mirror snapshot scheduler (rbd_support mgr module) calls `mirror_image_create_snapshot` synchronously in one thread loop for all mirroring images that require a snapshot. Taking that creating a snapshot is rather long operation (in my test environment it takes more than 1 second) it means that the scheduler has rather low limit of snapshot creation rate.

E.g. if one creates a mirroring pool with 100 images in snapshot mirror mode, and configure global 1 minute interval snapshot schedule, it is most likely the snapshot schedule will be lagging.

It can be improved, e.g. by implementing async version of `mirror_image_create_snapshot` and modifying the scheduler to create snapshots for many images in parallel.


Related issues 1 (0 open1 closed)

Copied to rbd - Backport #48091: octopus: scale up rbd mirror snapshot schedulerResolvedJason DillamanActions
Actions #1

Updated by Mykola Golub over 3 years ago

  • Pull request ID set to 37789
Actions #2

Updated by Jason Dillaman over 3 years ago

  • Status changed from In Progress to Pending Backport
  • Backport set to octopus
Actions #3

Updated by Nathan Cutler over 3 years ago

  • Copied to Backport #48091: octopus: scale up rbd mirror snapshot scheduler added
Actions #4

Updated by Nathan Cutler almost 3 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF