Project

General

Profile

Cleanup #47721

mgr/dashboard: Extract ng-bootstrap-form-validation

Added by Tiago Melo 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
dashboard/UI
Target version:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

This package tends to be outdated in relation to Angular and has some features that are always enabled and we never use them.
We should extract the used codebase from the plugin and implement it in out code.

If we check the Pool Form with ng profiler, we can see that not having that block of logic improves the performance:
Master:

ng.profiler.timeChangeDetection()
common_tools.ts:64 ran 1002 change detection cycles
common_tools.ts:65 0.50 ms per check
ChangeDetectionPerfRecord {msPerTick: 0.49930139727790107, numTicks: 1002}

PR:

ng.profiler.timeChangeDetection()
common_tools.ts:64 ran 1414 change detection cycles
common_tools.ts:65 0.35 ms per check
ChangeDetectionPerfRecord {msPerTick: 0.353758840174895, numTicks: 1414}
ng.profiler.timeChangeDetection()

History

#1 Updated by Tiago Melo 4 months ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 37512

#2 Updated by Lenz Grimmer 3 months ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v16.0.0

Also available in: Atom PDF