Project

General

Profile

Feature #4766

ceph-deploy: commands should continue to execute the next argument in case of failure

Added by Tamilarasi muthamizhan almost 11 years ago. Updated over 10 years ago.

Status:
Rejected
Priority:
High
Assignee:
-
Category:
ceph-deploy
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

currently, when trying to create multiple osds using the "osd create" command, the command returns failure when the first disk fails.

tamil@ubuntu:~/ceph-deploy-latest/ceph-deploy$ ./ceph-deploy osd create burnupi06:sdc burnupi07:sde burnupi07:sdf --zap-disk
ceph-disk: Error: Device is mounted: /dev/sdc1Traceback (most recent call last):
File "./ceph-deploy", line 9, in <module>
load_entry_point('ceph-deploy==0.0.1', 'console_scripts', 'ceph-deploy')()
File "/home/tamil/ceph-deploy-latest/ceph-deploy/ceph_deploy/cli.py", line 112, in main
return args.func(args)
File "/home/tamil/ceph-deploy-latest/ceph-deploy/ceph_deploy/osd.py", line 286, in osd
prepare(args, cfg, activate_prepared_disk=True)
File "/home/tamil/ceph-deploy-latest/ceph-deploy/ceph_deploy/osd.py", line 175, in prepare
dmcrypt_dir=args.dmcrypt_key_dir,
File "/home/tamil/ceph-deploy-latest/ceph-deploy/virtualenv/local/lib/python2.7/site-packages/pushy-0.5.1-py2.7.egg/pushy/protocol/proxy.py", line 255, in <lambda>
(conn.operator(type_, self, args, kwargs))
File "/home/tamil/ceph-deploy-latest/ceph-deploy/virtualenv/local/lib/python2.7/site-packages/pushy-0.5.1-py2.7.egg/pushy/protocol/connection.py", line 66, in operator
return self.send_request(type_, (object, args, kwargs))
File "/home/tamil/ceph-deploy-latest/ceph-deploy/virtualenv/local/lib/python2.7/site-packages/pushy-0.5.1-py2.7.egg/pushy/protocol/baseconnection.py", line 323, in send_request
return self.__handle(m)
File "/home/tamil/ceph-deploy-latest/ceph-deploy/virtualenv/local/lib/python2.7/site-packages/pushy-0.5.1-py2.7.egg/pushy/protocol/baseconnection.py", line 639, in __handle
raise e

pushy.protocol.proxy.ExceptionProxy: Command '['ceph-disk-prepare', '--zap-disk', '--', '/dev/sdc']' returned non-zero exit status 1

It would be nice, if it could continue with the other osds in the event of osd failures and finally report them in the ceph.log.

History

#1 Updated by Ian Colle almost 11 years ago

  • Priority changed from Normal to High

#2 Updated by Tamilarasi muthamizhan almost 11 years ago

  • Assignee deleted (Dan Mick)

#3 Updated by Tamilarasi muthamizhan almost 11 years ago

  • Subject changed from ceph-deploy: osd create command when used with multiple disks exits with the first disk failure to ceph-deploy: commands should continue to execute the next argument in case of failure

ceph-deploy commands [new, mon create, osd create,...] exit when any given argument fails. it is either in the beginning or in the middle of executing a string of multiple osds/mons.

It would be nice to continue with the next argument and finally exit.

#4 Updated by Tamilarasi muthamizhan almost 11 years ago

  • Target version deleted (v0.61 - Cuttlefish)

#5 Updated by Anonymous almost 11 years ago

  • Tracker changed from Bug to Feature

#6 Updated by Neil Levine over 10 years ago

  • Status changed from New to Rejected

Given the whole system is idempotent, I think it is better to fail as soon as there is an error so the user can look into the issue via the log.

Also available in: Atom PDF