Project

General

Profile

Bug #47652

teuthology's misc.sudo_write_file is incompatible with vstart_runner

Added by Rishabh Dave about 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Ramana Raja
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
qa
Pull request ID:
36457
Crash signature (v1):
Crash signature (v2):

Description

Here's the traceback -

2020-09-25 19:30:28,675.675 INFO:__main__:======================================================================
2020-09-25 19:30:28,675.675 INFO:__main__:ERROR: test_mount_all_caps_absent (tasks.cephfs.test_multifs_auth.TestClientsWithoutAuth)
2020-09-25 19:30:28,675.675 INFO:__main__:----------------------------------------------------------------------
2020-09-25 19:30:28,675.675 INFO:__main__:Traceback (most recent call last):
2020-09-25 19:30:28,675.675 INFO:__main__:  File "/home/rishabh/repos/ceph/minor/qa/tasks/cephfs/test_multifs_auth.py", line 277, in test_mount_all_caps_absent
2020-09-25 19:30:28,675.675 INFO:__main__:    keyring)
2020-09-25 19:30:28,675.675 INFO:__main__:  File "/home/rishabh/repos/ceph/minor/qa/tasks/cephfs/cephfs_test_case.py", line 439, in create_keyring_file
2020-09-25 19:30:28,675.675 INFO:__main__:    sudo_write_file(remote, keyring_path, keyring)
2020-09-25 19:30:28,675.675 INFO:__main__:  File "/home/rishabh/repos/teuthology/teuthology/misc.py", line 539, in sudo_write_file
2020-09-25 19:30:28,675.675 INFO:__main__:    remote.sudo_write_file(path, data, mode=perms, owner=owner)
2020-09-25 19:30:28,675.675 INFO:__main__:AttributeError: 'LocalRemote' object has no attribute 'sudo_write_file'

The compatibility was broken by this teuthology PR, since it makes teuthology.misc.sudo_write_file() call teuthology.remote.Remote.sudo_write_file() which in turn calls teuthology.remote.Remote.write_file() and vstart_runner.LocalRemote does not have a write_file() method

History

#1 Updated by Rishabh Dave about 3 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 37418

#2 Updated by Rishabh Dave about 3 years ago

The compatibility was broken by this teuthology PR, since it makes

"this teuthology PR": https://github.com/ceph/teuthology/pull/1538

#3 Updated by Rishabh Dave almost 3 years ago

  • Status changed from Fix Under Review to Resolved
  • Assignee changed from Rishabh Dave to Ramana Raja
  • Pull request ID changed from 37418 to 36457

Wasn't aware that Ramana too was working on the same issue. The fix was merged in commit https://github.com/ceph/ceph/pull/36457/commits/a177b470aa48a84e5346b310efa4fd626025dbfa.

Also available in: Atom PDF