Project

General

Profile

Actions
Copy link

Feature #47571

closed

mds: in->get_parent_dir() maybe NULL

Added by mingshuai wang over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
mingshuai wang
Category:
-
Target version:
v16.0.0
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:
37294

Description

bool MDCache::open_undef_inodes_dirfrags() {
.....

for (set<CInode*>::iterator p = rejoin_undef_inodes.begin();
       p != rejoin_undef_inodes.end();
       ++p) {
    CInode *in = *p;
    ceph_assert(!in->is_base());
    // parent是inode对应的dentry，parent->dir是dentry的父目录
    fetch_queue.insert(in->get_parent_dir());
  }

......

for (set<CDir*>::iterator p = fetch_queue.begin();
       p != fetch_queue.end();
       ++p) {
CDir *dir = *p; // maybe NULL Ptr for unexpected situation, it's better fail at begining
PR: https://github.com/ceph/ceph/pull/37294
Actions
Copy link
 #1

Updated by Patrick Donnelly over 3 years ago

  • Subject changed from MDS: in->get_parent_dir() maybe NULL to mds: in->get_parent_dir() maybe NULL
  • Status changed from New to Fix Under Review
  • Assignee set to mingshuai wang
  • Target version set to v16.0.0
  • Source set to Community (dev)
Actions
Copy link
 #2

Updated by Patrick Donnelly over 3 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link

Also available in: Atom PDF