Project

General

Profile

Actions

Bug #47560

closed

rbd-nbd: add --legacy and make --try-netlink as deprecated

Added by Xiubo Li over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Currently in nbd.ko module for the first time when loading,
it will add and initialize nbds_max(16 as default) nbd devices
defautly, and the udev service will try to open/close the
/dev/nbdX to do some sanity check.

And if we do the map at the same time we will hit some
errors, such the device is alredy in use, but it is actually not.

More detail please see the nbd-runner related code:
https://github.com/nbd-runner/nbd-runner/blob/master/client/nbd-cli-common.c#L318

Actions #1

Updated by Jason Dillaman over 3 years ago

... or alternatively we should attempt to issue a udev settle like krbd.

Actions #2

Updated by Xiubo Li over 3 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 37279
Actions #3

Updated by Xiubo Li over 3 years ago

  • Subject changed from rbd-nbd: set "nbds_max" to 0 as default when loading the nbd.ko to rbd-nbd: add --legacy and make --try-netlink as deprecated
Actions #4

Updated by Xiubo Li over 3 years ago

For RHEL/Centos we need to wait all the teuthology test node's kernel version be upgraded to kernel-4.18.0-193.9.el8 or larger versions to support the resize for netlink methods.

Actions #5

Updated by Xiubo Li over 3 years ago

Copied from the PR:

As part of this PR, we should switch to Ubuntu 20 (uses kernel v5.4) but we would need to pull 
the testing for RHEL/CentOS 8 until v8.3 is available in teuthology (open a tracker ticket so
we don't forget to re-add the testing). We should also add some text to PendingReleaseNotes to
annotate the change to rbd-nbd and its requirements for a more up-to-date kernel when using
the defaults.
Actions #6

Updated by Xiubo Li over 2 years ago

  • Status changed from Fix Under Review to Closed

Close it for now, will reopen it when needed.

Actions

Also available in: Atom PDF