Project

General

Profile

Actions
Copy link

Bug #47443

closed

Hybrid allocator might cause duplicate admin socket command registration.

Added by Igor Fedotov over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Igor Fedotov
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
octopus, nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
37149
Crash signature (v1):
Crash signature (v2):

Description

This is rather not a big deal for Octopus+ releases which has https://github.com/ceph/ceph/pull/30217
They use a single unregister_commands() call to unregister everything.

But for nautilus an assertion on a duplicate command de-registration might occur:
-12> 2020-09-11 12:14:37.869 7f4ad845aec0 5 asok(0x55ae57b4a000) unregister_command bluestore allocator dump bluefs-db
-11> 2020-09-11 12:14:37.869 7f4ad845aec0 5 asok(0x55ae57b4a000) unregister_command bluestore allocator score bluefs-db
-10> 2020-09-11 12:14:37.869 7f4ad845aec0 5 asok(0x55ae57b4a000) unregister_command bluestore allocator fragmentation bluefs-db
-9> 2020-09-11 12:14:37.869 7f4ad845aec0 5 asok(0x55ae57b4a000) unregister_commands bluestore bluefs available
-8> 2020-09-11 12:14:37.869 7f4ad845aec0 5 asok(0x55ae57b4a000) unregister_commands bluestore bluefs stats
-7> 2020-09-11 12:14:37.869 7f4ad845aec0 1 bdev(0x55ae58751180 /var/lib/ceph/osd/ceph-0/block) close
-6> 2020-09-11 12:14:38.196 7f4ad845aec0 1 fbmap_alloc 0x55ae5bc5e100 shutdown
-5> 2020-09-11 12:14:38.196 7f4ad845aec0 5 asok(0x55ae57b4a000) unregister_command bluestore allocator dump block
-4> 2020-09-11 12:14:38.196 7f4ad845aec0 5 asok(0x55ae57b4a000) unregister_command bluestore allocator score block
-3> 2020-09-11 12:14:38.196 7f4ad845aec0 5 asok(0x55ae57b4a000) unregister_command bluestore allocator fragmentation block
-2> 2020-09-11 12:14:38.196 7f4ad845aec0 5 asok(0x55ae57b4a000) unregister_command bluestore allocator dump block ENOENT
-1> 2020-09-11 12:14:38.198 7f4ad845aec0 -1 /home/jenkins-build/build/workspace/ceph-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos7/DIST/centos7/MACHINE_SIZE/gigantic/release/14.2.11/rpm/el7/BUILD/ceph-14.2.11/src/os/bluestore/Allocator.cc: In function 'virtual Allocator::SocketHook::~SocketHook()' thread 7f4ad845aec0 time 2020-09-11 12:14:38.197849
/home/jenkins-build/build/workspace/ceph-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos7/DIST/centos7/MACHINE_SIZE/gigantic/release/14.2.11/rpm/el7/BUILD/ceph-14.2.11/src/os/bluestore/Allocator.cc: 53: FAILED ceph_assert(r == 0)

Related issues 2 (0 open — 2 closed)

Copied to bluestore - Backport #47671: octopus: Hybrid allocator might cause duplicate admin socket command registration. ResolvedIgor FedotovActions
Copied to bluestore - Backport #47672: nautilus: Hybrid allocator might cause duplicate admin socket command registration. ResolvedActions
Actions
Copy link
 #1

Updated by Igor Fedotov over 3 years ago

  • Assignee set to Igor Fedotov
Actions
Copy link
 #2

Updated by Igor Fedotov over 3 years ago

  • Status changed from New to Fix Under Review
  • Backport set to octopus, nautilus
  • Pull request ID set to 37149
Actions
Copy link
 #3

Updated by Kefu Chai over 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #4

Updated by Nathan Cutler over 3 years ago

  • Copied to Backport #47671: octopus: Hybrid allocator might cause duplicate admin socket command registration. added
Actions
Copy link
 #5

Updated by Nathan Cutler over 3 years ago

  • Copied to Backport #47672: nautilus: Hybrid allocator might cause duplicate admin socket command registration. added
Actions
Copy link
 #6

Updated by Igor Fedotov over 3 years ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link

Also available in: Atom PDF