Project

General

Profile

Actions
Copy link

Bug #474

closed

mon: improve paxos commit batching

Added by Sage Weil over 13 years ago. Updated over 13 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Greg Farnum
Category:
Monitor
Target version:
v0.23
% Done:

0%

Source:
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

We should commit immediately if we haven't committed in the last 2 seconds. Currently we delay 2 seconds from the first change to batch changes, but that means single updates always take 2 seconds. This could even be a bit adaptive; the only reason for the delay is to avoid doing too many commits too quickly, generating lots of incrementals.

Actions
Copy link
 #1

Updated by Sage Weil over 13 years ago

  • Assignee set to Greg Farnum
Actions
Copy link
 #2

Updated by Greg Farnum over 13 years ago

  • Status changed from New to Resolved

Pushed a fix to unstable in 99013badb676986deb82757b77d91d0aa1f54cc9.
Instead of waiting g_conf.paxos_propose_interval seconds to comimt, we now wait until paxos_propose_interval seconds after the previous commit. If it's been more than paxos_propose_interval seconds, we wait g_conf.paxos_min_wait seconds. I set this to .05 seconds by default, in the hope that it will prevent a single OSD spawning multiple epochs on failure reports or something.

Actions
Copy link

Also available in: Atom PDF