Project

General

Profile

Bug #47367

mgr/volumes: volumes plugin does not ensure passed in subvolume name does not have more than one path component

Added by Shyamsundar Ranganathan over 3 years ago. Updated over 3 years ago.

Status:
New
Priority:
Normal
Category:
Correctness/Safety
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
octopus,nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
mgr/volumes
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The volumes plugin does not check and ensure that a subvolume name is passed as the parameter to calls that require the same. Instead it assumes the subvolume is at the specified path, and proceeds using the passed in subvolume name for operations.

This causes various side affects, like not finding the subvolume meta info file within the passed in path, and hence assuming the subvolume is a legacy subvolume etc.

To fix this, subvolume name needs to be validated across all calls in the volumes plugin.

Also, while doing this, other arguments to the various calls also need validation along these lines (for example, subvolumegroup argument)

History

#1 Updated by Shyamsundar Ranganathan over 3 years ago

  • Assignee set to Shyamsundar Ranganathan

Also available in: Atom PDF