Bug #4717: ssh: don't use tempnam - teuthology - Ceph

Actions

Copy link

Bug #4717

closed

ssh: don't use tempnam

Added by Greg Farnum about 11 years ago. Updated about 11 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Sam Lang

Category:

% Done:

Source:

Development

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Crash signature (v1):

Crash signature (v2):

Description

2013-04-12T10:49:48.302 INFO:teuthology.task.ssh_keys:cleaning up any left-over keys from previous tests
2013-04-12T10:49:48.411 INFO:teuthology.orchestra.run.err:-c:1: RuntimeWarning: tempnam is a potential security risk to your program
2013-04-12T10:49:48.767 INFO:teuthology.orchestra.run.err:-c:1: RuntimeWarning: tempnam is a potential security risk to your program
2013-04-12T10:49:49.101 INFO:teuthology.orchestra.run.err:-c:1: RuntimeWarning: tempnam is a potential security risk to your program
2013-04-12T10:49:49.459 INFO:teuthology.orchestra.run.err:-c:1: RuntimeWarning: tempnam is a potential security risk to your program

Etc. I gather this is a deprecated python function and there's a new thing you should use to replace it?

Actions

Copy link

Updated by Sam Lang about 11 years ago

Status changed from New to Fix Under Review
Assignee set to Anonymous

Pushed a fix to wip-4717. Joe can you review?

Actions

Copy link

Updated by Anonymous about 11 years ago

Assignee changed from Anonymous to Sam Lang

The general idea looks sound and I've confirmed that all the tests pass with the branch as it stands. There's one odd behavior (zero-length versions of the generated temp files exist after they are 'mv'ed into different locations. Tossing this back to Sam to sign-off on my additions to his branch.

Actions

Copy link