Project

General

Profile

Cleanup #47160

qa/tasks/cephfs: Break up test_volumes.py

Added by Ramana Raja 2 months ago. Updated 15 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Testing
Target version:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
qa-suite
Labels (FS):
qa
Pull request ID:

Description

The test_volumes has become unwieldy with growing number of non-trivial tests to test growing set of features in mgr/volumes. Adding/reviewing tests during code development and tracking down qa test run failures has become harder.

Solution as per Patrick Donnelly:
"To be clear: this is as simple as breaking the volumes tests into separate classes in teh same file. Then the yaml fragment [1] would be split into multiple yaml fragments that each refer to a specific class of tests."

[1] https://github.com/ceph/ceph/blob/d2a3fcc728c31b25166aeb55c99b9ccf8d4985bb/qa/suites/fs/basic_functional/tasks/volumes.yaml#L20

History

#1 Updated by Patrick Donnelly 2 months ago

To be clear: this is as simple as breaking the volumes tests into separate classes in teh same file. Then the yaml fragment [1] would be split into multiple yaml fragments that each refer to a specific class of tests.

[1] https://github.com/ceph/ceph/blob/d2a3fcc728c31b25166aeb55c99b9ccf8d4985bb/qa/suites/fs/basic_functional/tasks/volumes.yaml#L20

#2 Updated by Ramana Raja about 2 months ago

  • Subject changed from qa/tasks/cephfs: break up test_volumes.py into smaller modules to qa/tasks/cephfs: reak up test_volumes.py
  • Description updated (diff)
  • Assignee deleted (Shyamsundar Ranganathan)
  • Backport set to octopus,nautilus

#3 Updated by Ramana Raja about 2 months ago

  • Description updated (diff)

#4 Updated by Ramana Raja about 2 months ago

  • Subject changed from qa/tasks/cephfs: reak up test_volumes.py to qa/tasks/cephfs: Break up test_volumes.py

#5 Updated by Ramana Raja about 2 months ago

  • Status changed from New to In Progress
  • Assignee set to Ramana Raja

#6 Updated by Rishabh Dave 15 days ago

  • Pull request ID set to 37593

#7 Updated by Patrick Donnelly 15 days ago

  • Status changed from In Progress to Resolved
  • Backport deleted (octopus,nautilus)

I don't think this will be feasible to backport without significant effort. Ramana, do you think it's worth it?

Also available in: Atom PDF