Project

General

Profile

Bug #47054

mgr/volumes: Handle potential errors in readdir cephfs python binding

Added by Shyamsundar Ranganathan 8 months ago. Updated 3 months ago.

Status:
New
Priority:
Normal
Category:
Correctness/Safety
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
pacific,octopus,nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
cephfs.pyx, mgr/volumes
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Current implementation of the python binding in cephfs.pyx does not process errno in case of a nullptr return from readdir, that may signal an error.

Ref: https://github.com/ceph/ceph/blob/281dce82c0ad5419ce173dcd8b060fa52a0720fe/src/pybind/cephfs/cephfs.pyx#L424-L427

This can cause mgr-volumes to miss potential directory contents, if nullptr returns are assumed as end of listing, for example when checking for snapshots of a subvolume.

History

#1 Updated by Patrick Donnelly 8 months ago

  • Assignee set to Shyamsundar Ranganathan
  • Target version set to v16.0.0
  • Source set to Development

#2 Updated by Patrick Donnelly 3 months ago

  • Target version changed from v16.0.0 to v17.0.0
  • Backport changed from octopus,nautilus to pacific,octopus,nautilus

Also available in: Atom PDF