Project

General

Profile

Bug #4705

rbd: do a safe list traversal in rbd_img_request_submit()

Added by Alex Elder over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
04/10/2013
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
Yes?
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

It's possible that the reference to the object request dropped
inside the loop in rbd_img_request_submit() will be the last
one, in which case the content of the object pointer can't be
trusted.

Use a safe form of the object request list traversal to avoid
problems.

Signed-off-by: Alex Elder <>

History

#1 Updated by Alex Elder over 6 years ago

  • Status changed from In Progress to Need Review

The following has been posted for review:

[PATCH] rbd: do a safe list traversal in rbd_img_request_submit()

#2 Updated by Alex Elder over 6 years ago

  • Backport set to Yes?

I don't know how to fill in the "Backport" field. But this
may be a bug we should send to Linus for the current
cycle (3.9-rc7 is scheduled this weekend I think).

#3 Updated by Alex Elder over 6 years ago

  • Status changed from Need Review to Resolved

Sage sent a pull request for this patch today and Linus
accepted it already for Linux 3.9.

46faeed rbd: do a safe list traversal in rbd_img_request_submit()

#4 Updated by Alex Elder over 6 years ago

  • Target version set to v0.62a

Also available in: Atom PDF