Project

General

Profile

Bug #4694

client: put_snap_realm assert failure

Added by Greg Farnum about 8 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

2013-04-08T06:38:28.514 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err:./include/xlist.h: In function 'xlist<T>::~xlist() [with T = Inode*]' thread 7f65657fa700 time 2013-04-08 06:38:08.480144
2013-04-08T06:38:28.514 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err:./include/xlist.h: 69: FAILED assert(_size == 0)
2013-04-08T06:38:28.514 INFO:teuthology.orchestra.run.err:2013-04-08 06:38:08.481103 7f180eadd700  0 monclient: hunting for new mon
2013-04-08T06:38:28.521 DEBUG:teuthology.orchestra.run:Running [10.214.132.8]: '/home/ubuntu/cephtest/enable-coredump ceph-coverage /home/ubuntu/cephtest/archive/coverage ceph --concise mds dump --f
ormat=json'
2013-04-08T06:38:28.529 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err: ceph version 0.60-433-gf5ba0fb (f5ba0fbbe73e11418634bc95e1fc36d17edccf37)
2013-04-08T06:38:28.530 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err: 1: ceph-fuse() [0x4771dc]
2013-04-08T06:38:28.530 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err: 2: (Client::put_snap_realm(SnapRealm*)+0x226) [0x488716]
2013-04-08T06:38:28.530 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err: 3: (Client::send_reconnect(MetaSession*)+0x1137) [0x4c8437]
2013-04-08T06:38:28.530 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err: 4: (Client::handle_mds_map(MMDSMap*)+0x1254) [0x4c9e54]
2013-04-08T06:38:28.534 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err: 5: (Client::ms_dispatch(Message*)+0x43b) [0x4ca43b]
2013-04-08T06:38:28.534 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err: 6: (DispatchQueue::entry()+0x341) [0x643641]
2013-04-08T06:38:28.535 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err: 7: (DispatchQueue::DispatchThread::entry()+0xd) [0x582dcd]
2013-04-08T06:38:28.535 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err: 8: (()+0x7e9a) [0x7f656e927e9a]
2013-04-08T06:38:28.535 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err: 9: (clone()+0x6d) [0x7f656d34acbd]
2013-04-08T06:38:28.535 INFO:teuthology.task.ceph-fuse.ceph-fuse.0.err: NOTE: a copy of the executable, or `objdump -rdS <executable>` is needed to interpret this.

Logs at /a/teuthology-2013-04-08_02:45:19-fs-next-testing-basic/10271, including a core dump.

Associated revisions

Revision 4a84ddbd (diff)
Added by Sam Lang almost 8 years ago

client: Fix inode remove from snaprealm race

This is a follow on fix to b5ce4d0. Always remove the inode from the
snaprealm's list of inodes_with_caps before the snaprealm ref is
decremented (and the snaprealm potentially gets freed).

Fixes #4694.
Signed-off-by: Sam Lang <>
Reviewed-by: Greg Farnum <>

History

#1 Updated by Ian Colle about 8 years ago

  • Assignee set to Sam Lang

#2 Updated by Sam Lang almost 8 years ago

  • Status changed from New to Fix Under Review

Pushed wip-4694. Still trying to reproduce this reliably so that I can test the proposed fix.

#3 Updated by Greg Farnum almost 8 years ago

  • Status changed from Fix Under Review to Resolved

Looks good to me; I merged it into next. This was an impressively narrow race so we couldn't get a good reproducer going, but this patch fully explains everything I saw or heard about.

#4 Updated by Greg Farnum over 4 years ago

  • Component(FS) Client added

Also available in: Atom PDF