Project

General

Profile

Bug #46902

mds: CInode::maybe_export_pin is broken

Added by Zheng Yan 2 months ago. Updated 2 months ago.

Status:
New
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
octopus,nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDS
Labels (FS):
Pull request ID:
Crash signature:

Description

void CInode::maybe_export_pin(bool update) {
if (!g_conf()->mds_bal_export_pin)
return;
if (!is_dir() || !is_normal()) // this always return true
return;

History

#1 Updated by Patrick Donnelly 2 months ago

  • Assignee set to Zheng Yan
  • Target version set to v16.0.0
  • Source set to Development
  • Backport set to octopus,nautilus
  • Component(FS) MDS added

Zheng Yan wrote:

void CInode::maybe_export_pin(bool update) {
if (!g_conf()->mds_bal_export_pin)
return;
if (!is_dir() || !is_normal()) // this always return true
return;

Maybe the boolean evaluator in my brain is broken today but this looks right to me.

Also available in: Atom PDF