Project

General

Profile

Actions

Bug #46902

closed

mds: CInode::maybe_export_pin is broken

Added by Zheng Yan over 3 years ago. Updated over 2 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
pacific,octopus,nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDS
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

void CInode::maybe_export_pin(bool update) {
if (!g_conf()->mds_bal_export_pin)
return;
if (!is_dir() || !is_normal()) // this always return true
return;

Actions #1

Updated by Patrick Donnelly over 3 years ago

  • Assignee set to Zheng Yan
  • Target version set to v16.0.0
  • Source set to Development
  • Backport set to octopus,nautilus
  • Component(FS) MDS added

Zheng Yan wrote:

void CInode::maybe_export_pin(bool update) {
if (!g_conf()->mds_bal_export_pin)
return;
if (!is_dir() || !is_normal()) // this always return true
return;

Maybe the boolean evaluator in my brain is broken today but this looks right to me.

Actions #2

Updated by Patrick Donnelly over 3 years ago

  • Assignee deleted (Zheng Yan)
Actions #3

Updated by Patrick Donnelly over 3 years ago

  • Target version changed from v16.0.0 to v17.0.0
  • Backport changed from octopus,nautilus to pacific,octopus,nautilus
Actions #4

Updated by Patrick Donnelly over 2 years ago

  • Status changed from New to Rejected
Actions

Also available in: Atom PDF