Project

General

Profile

Bug #46869

mgr/dashboard: SCSS modules are breaking our current way of branding the dashboard

Added by Enno Gotthold 6 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
High
Category:
dashboard/UI
Target version:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
2 - major
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

As of PR https://github.com/ceph/ceph/pull/35501 the dashboard branding doesn't work like before.

This means that we need to adjust some code and of course also the HACKING.rst (see: [[https://github.com/ceph/ceph/pull/35954#discussion_r466950052]])

Current issues:
  • We have direct import of variables from '_bootstrap-defaults.scss'. Changing vars in vendor files will not update this.
  • We need to change the order of imports of '_bootstrap-defaults.scss' and 'vendor/variables'. ATM updating vendor variables is not updating the theme.
  • the @import of ceph custom styles can significantly increased the size of the build, depending on the content of 'vendor/variables'

Related issues

Related to mgr - Feature #45934: mgr/dashboard: Use SASS's new Modules instead of the old @import Resolved

History

#1 Updated by Tiago Melo 6 months ago

  • Subject changed from SCSS modules are breaking our current way of branding the dashboard to mgr/dashboard: SCSS modules are breaking our current way of branding the dashboard

#2 Updated by Tiago Melo 6 months ago

  • Description updated (diff)

#3 Updated by Tiago Melo 6 months ago

  • Description updated (diff)

#4 Updated by Tiago Melo 6 months ago

  • Description updated (diff)

#5 Updated by Tiago Melo 6 months ago

  • Description updated (diff)

#6 Updated by Tiago Melo 6 months ago

  • Description updated (diff)

#7 Updated by Lenz Grimmer 5 months ago

  • Assignee set to Sebastian Krah
  • Target version set to v16.0.0

#8 Updated by Alfonso Martínez 4 months ago

  • Related to Feature #45934: mgr/dashboard: Use SASS's new Modules instead of the old @import added

#9 Updated by Alfonso Martínez 4 months ago

  • Status changed from New to In Progress
  • Assignee changed from Sebastian Krah to Alfonso Martínez

#10 Updated by Alfonso Martínez 4 months ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 37617

#11 Updated by Lenz Grimmer 3 months ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF