Project

General

Profile

Cleanup #46802

mds: do not use asserts for RADOS failures

Added by Patrick Donnelly over 3 years ago. Updated over 1 year ago.

Status:
In Progress
Priority:
High
Assignee:
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
MDS
Labels (FS):
Pull request ID:

Description

https://github.com/ceph/ceph/blob/ec472b7b56eb5ed6ec52aa0bc4c2d18578f1e88c/src/mds/Server.cc#L371

and many others.

Some of these should be calling MDSRank::handle_write_error (like C_IO_MDC_TruncateFinish) if it's a RADOS write error. The others should abort with a more useful error message (including what the errno/errstring is).

History

#1 Updated by Patrick Donnelly over 3 years ago

  • Status changed from New to In Progress

#2 Updated by Patrick Donnelly about 3 years ago

  • Target version changed from v16.0.0 to v17.0.0
  • Backport changed from octopus,nautilus to pacific,octopus,nautilus

#3 Updated by Patrick Donnelly almost 3 years ago

  • Backport deleted (pacific,octopus,nautilus)

#4 Updated by Patrick Donnelly over 1 year ago

  • Target version deleted (v17.0.0)

Also available in: Atom PDF