Project

General

Profile

Actions

Tasks #46768

closed

Tasks #23844: client: break client_lock

client: clean up the unnecessary client_lock for _conf->client_trace

Added by Xiubo Li over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Performance/Resource Usage
Target version:
% Done:

0%

Tags:
Reviewed:
Affected Versions:
Component(FS):
Client
Labels (FS):
Pull request ID:

Description

There is no need to make the "cct->_conf->client_trace" under the
client_lock, it is for the "ceph-syn" and it almost won't change,
even it will but it still won't cause any race.

For the "inode->ino" and "inode->snapid", since they won't change
once initialized when creating the inode, and the inode here will
be protected by the reference count, so no need the client_lock too.

Actions #1

Updated by Xiubo Li over 3 years ago

  • Pull request ID set to 36364
Actions #2

Updated by Xiubo Li over 3 years ago

  • Status changed from New to Fix Under Review
Actions #3

Updated by Patrick Donnelly over 3 years ago

  • Category set to Performance/Resource Usage
  • Status changed from Fix Under Review to Resolved
  • Target version set to v16.0.0
Actions

Also available in: Atom PDF