Project

General

Profile

Actions

Cleanup #46750

closed

mgr/dashboard: Merge disable and disableDesc table action methods

Added by Tiago Melo over 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
General
Target version:
% Done:

0%

Tags:
Backport:
octopus
Reviewed:
Affected Versions:
Pull request ID:

Description

Currently we have to separate methods to calculate if a action is disabled and if it should display any description.
By merging both we reduce duplicated code, keeping the same functionality.


Related issues 2 (0 open2 closed)

Copied to Dashboard - Backport #47943: octopus: mgr/dashboard: Merge disable and disableDesc table action methodsResolvedKiefer ChangActions
Copied to Dashboard - Backport #49624: nautilus: mgr/dashboard: Merge disable and disableDesc table action methodsRejectedActions
Actions #1

Updated by Tiago Melo over 3 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 36345
Actions #2

Updated by Lenz Grimmer over 3 years ago

  • Translation missing: en.field_tag_list set to low-hanging-fruit, refactoring
  • Target version set to v16.0.0
Actions #3

Updated by Tiago Melo over 3 years ago

  • Status changed from Fix Under Review to Resolved
Actions #4

Updated by Kiefer Chang over 3 years ago

  • Backport set to octopus

Add octopus backport because this is needed for #47019

Actions #5

Updated by Kiefer Chang over 3 years ago

  • Status changed from Resolved to Pending Backport
Actions #6

Updated by Nathan Cutler over 3 years ago

  • Copied to Backport #47943: octopus: mgr/dashboard: Merge disable and disableDesc table action methods added
Actions #7

Updated by Nathan Cutler over 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions #8

Updated by Ernesto Puerta about 3 years ago

  • Status changed from Resolved to Pending Backport
  • Backport changed from octopus to octopus, nautilus
Actions #9

Updated by Backport Bot about 3 years ago

  • Copied to Backport #49624: nautilus: mgr/dashboard: Merge disable and disableDesc table action methods added
Actions #10

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 132 to General
Actions #11

Updated by Ernesto Puerta almost 3 years ago

  • Status changed from Pending Backport to Resolved
  • Backport changed from octopus, nautilus to octopus
Actions

Also available in: Atom PDF