Project

General

Profile

Cleanup #46750

mgr/dashboard: Merge disable and disableDesc table action methods

Added by Tiago Melo 6 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
dashboard/general
Target version:
% Done:

0%

Tags:
Backport:
octopus
Reviewed:
Affected Versions:
Pull request ID:

Description

Currently we have to separate methods to calculate if a action is disabled and if it should display any description.
By merging both we reduce duplicated code, keeping the same functionality.


Related issues

Copied to mgr - Backport #47943: octopus: mgr/dashboard: Merge disable and disableDesc table action methods Resolved

History

#1 Updated by Tiago Melo 6 months ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 36345

#2 Updated by Lenz Grimmer 6 months ago

  • Tags set to low-hanging-fruit, refactoring
  • Target version set to v16.0.0

#3 Updated by Tiago Melo 6 months ago

  • Status changed from Fix Under Review to Resolved

#4 Updated by Kiefer Chang 3 months ago

  • Backport set to octopus

Add octopus backport because this is needed for #47019

#5 Updated by Kiefer Chang 3 months ago

  • Status changed from Resolved to Pending Backport

#6 Updated by Nathan Cutler 3 months ago

  • Copied to Backport #47943: octopus: mgr/dashboard: Merge disable and disableDesc table action methods added

#7 Updated by Nathan Cutler about 2 months ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Also available in: Atom PDF