Project

General

Profile

Actions

Bug #46745

closed

cephadm does not set systemd dependencies when using docker

Added by Michal Nasiadka over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
cephadm
Target version:
-
% Done:

0%

Source:
Tags:
low-hanging-fruit
Backport:
pacific, octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

When using docker - systemd units produced by cephadm do not have any dependencies to docker.service
The effect is that when a user issues docker.service restart - ceph systemd services are not restarted (and are in running state, although they are dead in docker ps -a output)


Related issues 1 (0 open1 closed)

Has duplicate Orchestrator - Bug #48891: cephadm does not set required dependencies in systemdDuplicate

Actions
Actions #1

Updated by Michal Nasiadka over 3 years ago

Putting following in systemd unit file solves the issue

After=network-online.target local-fs.target time-sync.target docker.service
Requires=docker.service

(the same is done by ceph-ansible - https://github.com/ceph/ceph-ansible/blob/a6209bd957e40c9c42370eab73ae99e73d53c8a4/roles/ceph-osd/templates/ceph-osd.service.j2#L5)

Actions #2

Updated by Sebastian Wagner over 3 years ago

  • Priority changed from Normal to High
  • Tags set to low-hanging-fruit
Actions #3

Updated by Sebastian Wagner over 3 years ago

  • Has duplicate Bug #48891: cephadm does not set required dependencies in systemd added
Actions #4

Updated by Sage Weil about 3 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 39770
Actions #5

Updated by Sebastian Wagner about 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #6

Updated by Sage Weil about 3 years ago

  • Status changed from Pending Backport to Resolved
  • Backport set to pacific
Actions #7

Updated by Loïc Dachary about 3 years ago

  • Status changed from Resolved to Pending Backport
  • Backport changed from pacific to octopus
Actions #8

Updated by Loïc Dachary about 3 years ago

  • Status changed from Pending Backport to Resolved
  • Backport changed from octopus to pacific, octopus
Actions #9

Updated by Loïc Dachary about 3 years ago

For the record, the Octopus backport is at https://github.com/ceph/ceph/pull/39804

Actions

Also available in: Atom PDF