Project

General

Profile

Actions
Copy link

Bug #46733

closed

Erro:EEXIST returned while unprotecting a snap which is not protected

Added by Humble Chirammal over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Kotresh Hiremath Ravishankar
Category:
-
Target version:
Ceph - v16.0.0
% Done:

0%

Source:
Development
Tags:
Backport:
octopus,nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
libcephfs, mgr/volumes
Labels (FS):
snapshots
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Double unprotect or unprotect on a snap which is not protected give EEXIST error code.
[root@node /]# ceph fs subvolume snapshot protect cephfilesystem vol1 hum-snap1 csi
[root@node /]# ceph fs subvolume snapshot unprotect cephfilesystem vol1 hum-snap1 csi
[root@node /]# ceph fs subvolume snapshot unprotect cephfilesystem vol1 hum-snap1 csi
Error EEXIST: snapshot 'hum-snap1' is not protected

IMO, EEXIST does not make much sense in this context, May be 'no error' or 'some other error code' would be the correct thing to do.
This add additional overhead to the caller while doing `unproect` check before deleting the volume.

Actions
Copy link
 #1

Updated by Patrick Donnelly over 3 years ago

  • Status changed from New to Triaged
  • Assignee set to Kotresh Hiremath Ravishankar
  • Target version set to v16.0.0
  • Source set to Development
  • Backport set to octopus,nautilus
  • Component(FS) mgr/volumes added
Actions
Copy link
 #2

Updated by Kotresh Hiremath Ravishankar over 3 years ago

  • Status changed from Triaged to Closed

This issue no longer occurs as the protect/unprotect is deprecated with https://tracker.ceph.com/issues/45371
The protect/unprotect still exists for backward compatibility reasons but does no op. So this issue doesn't occur.

Please track the following back port trackers for the availability in the releases.

1. https://tracker.ceph.com/issues/46527
2. https://tracker.ceph.com/issues/46528

Closing this tracker for above mentioned reasons.

Actions
Copy link

Also available in: Atom PDF