Project

General

Profile

Actions
Copy link

Bug #46406

closed

pybind/mgr/balancer: should use "==" and "!=" for comparing strings

Added by Kefu Chai almost 4 years ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Kefu Chai
Category:
balancer module
Target version:
-
% Done:

100%

Source:
Q/A
Tags:
Backport:
nautilus, octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
35943
Crash signature (v1):
Crash signature (v2):

Description

"is" is just not correct. as we cannot guarantee that two strings with the same value share the same identity.

Related issues 2 (0 open — 2 closed)

Copied to RADOS - Backport #46460: octopus: pybind/mgr/balancer: should use "==" and "!=" for comparing stringsResolvedNathan CutlerActions
Copied to RADOS - Backport #46461: nautilus: pybind/mgr/balancer: should use "==" and "!=" for comparing stringsResolvedNathan CutlerActions
Actions
Copy link
 #1

Updated by Kefu Chai almost 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #2

Updated by Nathan Cutler almost 4 years ago

  • Copied to Backport #46460: octopus: pybind/mgr/balancer: should use "==" and "!=" for comparing strings added
Actions
Copy link
 #3

Updated by Nathan Cutler almost 4 years ago

  • Copied to Backport #46461: nautilus: pybind/mgr/balancer: should use "==" and "!=" for comparing strings added
Actions
Copy link
 #4

Updated by Nathan Cutler over 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link
 #5

Updated by Konstantin Shalygin 8 months ago

  • Project changed from RADOS to mgr
  • Category set to balancer module
  • % Done changed from 0 to 100
  • Source set to Q/A
Actions
Copy link

Also available in: Atom PDF