Project

General

Profile

Bug #46406

pybind/mgr/balancer: should use "==" and "!=" for comparing strings

Added by Kefu Chai 4 months ago. Updated 20 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus, octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
Crash signature:

Description

"is" is just not correct. as we cannot guarantee that two strings with the same value share the same identity.


Related issues

Copied to RADOS - Backport #46460: octopus: pybind/mgr/balancer: should use "==" and "!=" for comparing strings Resolved
Copied to RADOS - Backport #46461: nautilus: pybind/mgr/balancer: should use "==" and "!=" for comparing strings Resolved

History

#1 Updated by Kefu Chai 4 months ago

  • Status changed from Fix Under Review to Pending Backport

#2 Updated by Nathan Cutler 3 months ago

  • Copied to Backport #46460: octopus: pybind/mgr/balancer: should use "==" and "!=" for comparing strings added

#3 Updated by Nathan Cutler 3 months ago

  • Copied to Backport #46461: nautilus: pybind/mgr/balancer: should use "==" and "!=" for comparing strings added

#4 Updated by Nathan Cutler 20 days ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Also available in: Atom PDF