https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2020-07-06T13:48:06ZCeph CephFS - Bug #46278: mds: Subvolume snapshot directory does not save attribute "ceph.quota.max_bytes" of snapshot source directory treehttps://tracker.ceph.com/issues/46278?journal_id=1697582020-07-06T13:48:06ZPatrick Donnellypdonnell@redhat.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Triaged</i></li><li><strong>Assignee</strong> set to <i>Zheng Yan</i></li><li><strong>Target version</strong> set to <i>v16.0.0</i></li><li><strong>Backport</strong> set to <i>octopus,nautilus</i></li><li><strong>Labels (FS)</strong> <i>snapshots</i> added</li></ul> CephFS - Bug #46278: mds: Subvolume snapshot directory does not save attribute "ceph.quota.max_bytes" of snapshot source directory treehttps://tracker.ceph.com/issues/46278?journal_id=1698762020-07-07T12:18:45ZZheng Yanukernel@gmail.com
<ul></ul><p>try following patch<br /><pre>
diff --git a/src/client/Client.cc b/src/client/Client.cc
index 847cfb7b65..d1944499c6 100644
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -11854,7 +11854,8 @@ int Client::ll_removexattr(Inode *in, const char *name, const UserPerm& perms)
bool Client::_vxattrcb_quota_exists(Inode *in)
{
return in->quota.is_enable() &&
- in->snaprealm && in->snaprealm->ino == in->ino;
+ (in->snapid != CEPH_NOSNAP ||
+ (in->snaprealm && in->snaprealm->ino == in->ino));
}
size_t Client::_vxattrcb_quota(Inode *in, char *val, size_t size)
{
</pre></p> CephFS - Bug #46278: mds: Subvolume snapshot directory does not save attribute "ceph.quota.max_bytes" of snapshot source directory treehttps://tracker.ceph.com/issues/46278?journal_id=1699712020-07-08T14:05:24ZShyamsundar Ranganathan
<ul></ul><p>Zheng Yan wrote:</p>
<blockquote>
<p>try following patch<br />[...]</p>
</blockquote>
<p>Thanks, tested with ceph-fuse and setting the quota as before and inspecting the snapshots. The snapshot directories now return the required xattr information as required with the patch. Thanks!</p>
<p>(jFYI) We would need the fix for the kernel clients as well as ceph-csi prefers to use the kernel client.</p> CephFS - Bug #46278: mds: Subvolume snapshot directory does not save attribute "ceph.quota.max_bytes" of snapshot source directory treehttps://tracker.ceph.com/issues/46278?journal_id=1706652020-07-15T20:31:56ZShyamsundar Ranganathan
<ul></ul><p>The fix may not be required from the kernel clients in addition to libcephfs, as volume manager is the entity that would read and apply this to a clone, which uses libcephfs.</p> CephFS - Bug #46278: mds: Subvolume snapshot directory does not save attribute "ceph.quota.max_bytes" of snapshot source directory treehttps://tracker.ceph.com/issues/46278?journal_id=1714432020-07-23T02:21:12ZPatrick Donnellypdonnell@redhat.com
<ul><li><strong>Status</strong> changed from <i>Triaged</i> to <i>Fix Under Review</i></li><li><strong>Assignee</strong> changed from <i>Zheng Yan</i> to <i>Shyamsundar Ranganathan</i></li><li><strong>Pull request ID</strong> set to <i>36249</i></li></ul> CephFS - Bug #46278: mds: Subvolume snapshot directory does not save attribute "ceph.quota.max_bytes" of snapshot source directory treehttps://tracker.ceph.com/issues/46278?journal_id=1719352020-07-30T03:06:42ZPatrick Donnellypdonnell@redhat.com
<ul><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Pending Backport</i></li></ul> CephFS - Bug #46278: mds: Subvolume snapshot directory does not save attribute "ceph.quota.max_bytes" of snapshot source directory treehttps://tracker.ceph.com/issues/46278?journal_id=1720752020-07-31T10:32:32ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-9 status-3 priority-4 priority-default closed" href="/issues/46795">Backport #46795</a>: octopus: mds: Subvolume snapshot directory does not save attribute "ceph.quota.max_bytes" of snapshot source directory tree</i> added</li></ul> CephFS - Bug #46278: mds: Subvolume snapshot directory does not save attribute "ceph.quota.max_bytes" of snapshot source directory treehttps://tracker.ceph.com/issues/46278?journal_id=1720772020-07-31T10:32:40ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-9 status-3 priority-4 priority-default closed" href="/issues/46796">Backport #46796</a>: nautilus: mds: Subvolume snapshot directory does not save attribute "ceph.quota.max_bytes" of snapshot source directory tree</i> added</li></ul> CephFS - Bug #46278: mds: Subvolume snapshot directory does not save attribute "ceph.quota.max_bytes" of snapshot source directory treehttps://tracker.ceph.com/issues/46278?journal_id=1740282020-08-28T14:39:46ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Status</strong> changed from <i>Pending Backport</i> to <i>Resolved</i></li></ul><p>While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".</p>