Project

General

Profile

Bug #46277

pybind/mgr/volumes: get_pool_names may indicate volume does not exist if multiple volumes exist

Added by Patrick Donnelly 13 days ago. Updated 5 days ago.

Status:
Pending Backport
Priority:
High
Category:
-
Target version:
% Done:

0%

Source:
Q/A
Tags:
Backport:
octopus,nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
mgr/volumes
Labels (FS):
Pull request ID:
Crash signature:

Description

2020-06-30T01:08:22.680+0000 7f64d590d700  1 -- [v2:172.21.15.159:6834/29541,v1:172.21.15.159:6835/29541] <== client.35563 172.21.15.195:0/3884091032 1 ==== mgr_command(tid 0: {"prefix": "fs volume rm", "vol_name": "volume_2830", "yes-i-really-mean-it": "--yes-i-really-mean-it", "target": ["mon-mgr", ""]}) v1 ==== 154+0+0 (secure 0 0 0) 0x556538ed0dc0 con 0x5565525e8000
2020-06-30T01:08:22.680+0000 7f64d590d700 10 mgr.server _handle_command decoded-size=4 prefix=fs volume rm
2020-06-30T01:08:22.680+0000 7f64d590d700 20 is_capable service=py module=volumes command=fs volume rm read write addr - on cap allow *
2020-06-30T01:08:22.680+0000 7f64d590d700 20  allow so far , doing grant allow *
2020-06-30T01:08:22.680+0000 7f64d590d700 20  allow all
2020-06-30T01:08:22.680+0000 7f64d590d700 10 mgr.server _allowed_command  client.admin capable
2020-06-30T01:08:22.680+0000 7f64d590d700  0 log_channel(audit) log [DBG] : from='client.35563 -' entity='client.admin' cmd=[{"prefix": "fs volume rm", "vol_name": "volume_2830", "yes-i-really-mean-it": "--yes-i-really-mean-it", "target": ["mon-mgr", ""]}]: dispatch
2020-06-30T01:08:22.680+0000 7f64d590d700 10 mgr.server _handle_command passing through 4
2020-06-30T01:08:22.680+0000 7f64d310b700 20 mgr Gil Switched to new thread state 0x556534340400
2020-06-30T01:08:22.680+0000 7f64d310b700 20 mgr ~Gil Destroying new thread state 0x556534340400
2020-06-30T01:08:22.680+0000 7f64d310b700 -1 mgr.server reply reply (2) No such file or directory volume volume_2830 doesn't exist

From: /ceph/teuthology-archive/pdonnell-2020-06-29_23:19:06-fs-wip-pdonnell-testing-20200629.214056-distro-basic-smithi/5190409/remote/smithi159/log/ceph-mgr.x.log.gz

Caused by https://github.com/ceph/ceph/blob/265055019218ee63b65f57251a5c8cd8768087f5/src/pybind/mgr/volumes/fs/operations/volume.py#L30-L34

The return (failure) should only occur if nothing is found after looping through the fsmap.


Related issues

Copied to fs - Backport #46465: octopus: pybind/mgr/volumes: get_pool_names may indicate volume does not exist if multiple volumes exist New
Copied to fs - Backport #46466: nautilus: pybind/mgr/volumes: get_pool_names may indicate volume does not exist if multiple volumes exist New

History

#1 Updated by Patrick Donnelly 13 days ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 35857

#2 Updated by Patrick Donnelly 5 days ago

  • Status changed from Fix Under Review to Pending Backport

#3 Updated by Nathan Cutler 3 days ago

  • Copied to Backport #46465: octopus: pybind/mgr/volumes: get_pool_names may indicate volume does not exist if multiple volumes exist added

#4 Updated by Nathan Cutler 3 days ago

  • Copied to Backport #46466: nautilus: pybind/mgr/volumes: get_pool_names may indicate volume does not exist if multiple volumes exist added

Also available in: Atom PDF