Bug #46264: mon: check for mismatched daemon versions - RADOS - Ceph

Actions

Copy link

Bug #46264

closed

mon: check for mismatched daemon versions

Added by Tyler Sheehan almost 4 years ago. Updated over 3 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

David Zafman

Category:

Target version:

% Done:

Source:

Community (dev)

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(RADOS):

Pull request ID:

36759

Crash signature (v1):

Crash signature (v2):

Description

There is currently no test to check if the daemon are all running the same version of ceph

Related issues 1 (1 open — 0 closed)

Actions

Copy link

Updated by Sebastian Wagner almost 4 years ago

Hm. what do yo expect? Upgrade scenarios can become complicated with more than two versions running at the same time while doing an upgrade. What do you have in mind?

Actions

Copy link

Updated by Tyler Sheehan almost 4 years ago

I have completed a function called check_daemon_version located in src/mon/Monitor.cc This function goes through mon_metadata checking the version of each daemon against the version of the first daemon, if there are any that do not match their rank is added to a map function and returned along with the value true, once returned the map is cycled through in src/mon/HealthMonitor.cc file function get_health_status() where the rank is used to get the name of each daemon and return them. Their is an if statement inside HealthMintor.cc that ensures even if check_daemon_version returns true the error message will only occur if a specific amount of time has passed and check_daemon_version returns true again.
If you wish to take a look at the code you can check the current pull request located here: https://github.com/ceph/ceph/pull/35876

Actions

Copy link

Updated by Neha Ojha over 3 years ago

Project changed from Ceph to RADOS
Subject changed from mon:add test for daemon versions to mon:check for mismatched daemon versions
Category deleted (~~Monitor~~)
Status changed from New to Fix Under Review
Assignee set to Tyler Sheehan
Pull request ID set to 35876