Project

General

Profile

Actions
Copy link

Feature #46226

open

msg: Messenger should log when it reaches the DispatchQueue throttle limit

Added by Jos Collin almost 4 years ago. Updated almost 2 years ago.

Status:
Fix Under Review
Priority:
Normal
Assignee:
Jos Collin
Category:
-
Target version:
Ceph - v16.0.0
% Done:

0%

Source:
Development
Tags:
Backport:
pacific,octopus,nautilus
Reviewed:
Affected Versions:
Pull request ID:
39510

Description

Right now there is no low debug output indicating that the throttle is reached which, in production, can give the appearance of network issues. In particular, hitting the DispatchQueue::dispatch_throttler limit will even prevent fast dispatch of critical messages. There should be a message whenever we hit the limit and a debug message has not been output recently (30 seconds?).

Related issues 1 (0 open — 1 closed)

Related to RADOS - Bug #56495: Log at 1 when Throttle::get_or_fail() failsResolvedBrad Hubbard

Actions
Actions
Copy link
 #1

Updated by Patrick Donnelly almost 4 years ago

  • Project changed from CephFS to Ceph
  • Category deleted (Correctness/Safety)
  • Status changed from New to In Progress
  • Assignee set to Jos Collin
  • Target version set to v16.0.0
  • Backport set to octopus,nautilus
Actions
Copy link
 #2

Updated by Patrick Donnelly almost 4 years ago

  • Project changed from Ceph to Messengers
Actions
Copy link
 #3

Updated by Jos Collin almost 4 years ago

  • Pull request ID set to 36135
Actions
Copy link
 #4

Updated by Jos Collin over 3 years ago

  • Pull request ID changed from 36135 to 37954
Actions
Copy link
 #5

Updated by Jos Collin over 3 years ago

  • Status changed from In Progress to Fix Under Review
Actions
Copy link
 #6

Updated by Jos Collin about 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #9

Updated by Jos Collin about 3 years ago

  • Backport changed from octopus,nautilus to pacific,octopus,nautilus
Actions
Copy link
 #11

Updated by Jos Collin about 3 years ago

  • Status changed from Pending Backport to In Progress
Actions
Copy link
 #12

Updated by Jos Collin about 3 years ago

  • Pull request ID deleted (37954)
Actions
Copy link
 #13

Updated by Jos Collin about 3 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 39510
Actions
Copy link
 #14

Updated by Nathan Cutler about 3 years ago

I deleted the prematurely opened backport issues because they were showing up in the backport listings and creating confusion for backporters.

Once the master PR gets merged, the Backport Bot will open new backport issues, so nothing is lost.

Actions
Copy link
 #15

Updated by Brad Hubbard almost 2 years ago

https://tracker.ceph.com/issues/56495 is a quick and at least partial fix for this.

Actions
Copy link
 #16

Updated by Brad Hubbard almost 2 years ago

  • Related to Bug #56495: Log at 1 when Throttle::get_or_fail() fails added
Actions
Copy link

Also available in: Atom PDF