Project

General

Profile

Actions
Copy link

Fix #4612

closed

unit_to_bytesize(), si_t, prettybyte_t use 'K' for kilo; SI recommends 'k'

Added by Dan Mick about 11 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Dan Mick
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

It's a pet peeve, but the abbreviation for "kilo" (or "kibi") is 'k', not 'K'.
I'm happy with making it both, but we can't not accept 'k'.

Actions
Copy link
 #1

Updated by Ian Colle about 11 years ago

  • Assignee set to Dan Mick
Actions
Copy link
 #2

Updated by Anonymous almost 11 years ago

  • Project changed from Ceph to 16
Actions
Copy link
 #3

Updated by Ian Colle almost 11 years ago

  • Project changed from 16 to Ceph
Actions
Copy link
 #4

Updated by Dan Mick almost 11 years ago

  • Subject changed from unit_to_bytestring: uses 'K' for kilo; SI recommends 'k' to si_t, prettybyte_t use 'K' for kilo; SI recommends 'k'
Actions
Copy link
 #5

Updated by Sage Weil over 10 years ago

  • Tracker changed from Bug to Fix
Actions
Copy link
 #6

Updated by Dan Mick over 10 years ago

This is now parsed as input in unit_to_bytesize(), and printed in the various classes
in types.h. Fix both sides (allow both on input, use lowercase on output).

Actions
Copy link
 #7

Updated by Dan Mick over 10 years ago

  • Status changed from New to Fix Under Review
Actions
Copy link
 #8

Updated by Dan Mick over 10 years ago

  • Subject changed from si_t, prettybyte_t use 'K' for kilo; SI recommends 'k' to unit_to_bytesize(), si_t, prettybyte_t use 'K' for kilo; SI recommends 'k'
Actions
Copy link
 #9

Updated by Sage Weil over 10 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link

Also available in: Atom PDF